From: tip-bot for Peng Hao <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org,
peng.hao2@zte.com.cn, mingo@kernel.org, hpa@zytor.com
Subject: [tip:timers/core] tick/broadcast: Remove redundant check
Date: Fri, 28 Sep 2018 13:33:52 -0700 [thread overview]
Message-ID: <tip-dc6253108f0fbff4a634055d5b8a91958ec2af81@git.kernel.org> (raw)
In-Reply-To: <1538150608-2599-1-git-send-email-penghao122@sina.com.cn>
Commit-ID: dc6253108f0fbff4a634055d5b8a91958ec2af81
Gitweb: https://git.kernel.org/tip/dc6253108f0fbff4a634055d5b8a91958ec2af81
Author: Peng Hao <peng.hao2@zte.com.cn>
AuthorDate: Fri, 28 Sep 2018 12:03:28 -0400
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 28 Sep 2018 22:29:35 +0200
tick/broadcast: Remove redundant check
tick_device_is_functional() is called early in tick_broadcast_control(), so
no need to call it again later.
Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: fweisbec@gmail.com
Link: https://lkml.kernel.org/r/1538150608-2599-1-git-send-email-penghao122@sina.com.cn
---
kernel/time/tick-broadcast.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c
index aa2094d5dd27..be0aac2b4300 100644
--- a/kernel/time/tick-broadcast.c
+++ b/kernel/time/tick-broadcast.c
@@ -400,8 +400,6 @@ void tick_broadcast_control(enum tick_broadcast_mode mode)
if (tick_broadcast_forced)
break;
cpumask_clear_cpu(cpu, tick_broadcast_on);
- if (!tick_device_is_functional(dev))
- break;
if (cpumask_test_and_clear_cpu(cpu, tick_broadcast_mask)) {
if (tick_broadcast_device.mode ==
TICKDEV_MODE_PERIODIC)
prev parent reply other threads:[~2018-09-28 20:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 16:03 [PATCH] tick: remove unnecssary check Peng Hao
2018-09-28 20:33 ` tip-bot for Peng Hao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-dc6253108f0fbff4a634055d5b8a91958ec2af81@git.kernel.org \
--to=tipbot@zytor.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peng.hao2@zte.com.cn \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome