From: tip-bot for Ganapatrao Kulkarni <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: gklkml16@gmail.com, mark.rutland@arm.com,
zhangshaokun@hisilicon.com, hpa@zytor.com, acme@redhat.com,
linux-kernel@vger.kernel.org, jonathan.cameron@huawei.com,
catalin.marinas@arm.com, tglx@linutronix.de,
robert.richter@cavium.com, will.deacon@arm.com,
jnair@caviumnetworks.com, ganapatrao.kulkarni@cavium.com,
mingo@kernel.org, peterz@infradead.org,
alexander.shishkin@linux.intel.com
Subject: [tip:perf/core] perf pmu: Add check for valid cpuid in perf_pmu__find_map()
Date: Wed, 6 Dec 2017 08:40:20 -0800 [thread overview]
Message-ID: <tip-de3d0f12be476271d03f1ddb5a7c241c2f07f126@git.kernel.org> (raw)
In-Reply-To: <20171016183222.25750-6-ganapatrao.kulkarni@cavium.com>
Commit-ID: de3d0f12be476271d03f1ddb5a7c241c2f07f126
Gitweb: https://git.kernel.org/tip/de3d0f12be476271d03f1ddb5a7c241c2f07f126
Author: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
AuthorDate: Tue, 17 Oct 2017 00:02:22 +0530
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 5 Dec 2017 15:43:51 -0300
perf pmu: Add check for valid cpuid in perf_pmu__find_map()
On some platforms(arm/arm64) which uses cpus map to get corresponding
cpuid string, cpuid can be NULL for PMUs other than CORE PMUs. Adding
check for NULL cpuid in function perf_pmu__find_map to avoid
segmentation fault.
Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Ganapatrao Kulkarni <gklkml16@gmail.com>
Cc: Jayachandran C <jnair@caviumnetworks.com>
Cc: Jonathan Cameron <jonathan.cameron@huawei.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Robert Richter <robert.richter@cavium.com>
Cc: Shaokun Zhang <zhangshaokun@hisilicon.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: linux-arm-kernel@lists.infradead.org
Link: http://lkml.kernel.org/r/20171016183222.25750-6-ganapatrao.kulkarni@cavium.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/pmu.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
index 732ff57..8b7c151 100644
--- a/tools/perf/util/pmu.c
+++ b/tools/perf/util/pmu.c
@@ -601,6 +601,12 @@ struct pmu_events_map *perf_pmu__find_map(struct perf_pmu *pmu)
char *cpuid = perf_pmu__getcpuid(pmu);
int i;
+ /* on some platforms which uses cpus map, cpuid can be NULL for
+ * PMUs other than CORE PMUs.
+ */
+ if (!cpuid)
+ return NULL;
+
i = 0;
for (;;) {
map = &pmu_events_map[i++];
next prev parent reply other threads:[~2017-12-06 16:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 18:32 [PATCH v9 0/5] Add support for ThunderX2 pmu events using json files Ganapatrao Kulkarni
2017-10-16 18:32 ` [PATCH v9 1/5] perf utils: passing pmu as a parameter to function get_cpuid_str Ganapatrao Kulkarni
2017-12-06 16:38 ` [tip:perf/core] perf pmu: Pass pmu as a parameter to get_cpuid_str() tip-bot for Ganapatrao Kulkarni
2017-10-16 18:32 ` [PATCH v9 2/5] perf tools arm64: Add support for get_cpuid_str function Ganapatrao Kulkarni
2017-12-06 16:39 ` [tip:perf/core] " tip-bot for Ganapatrao Kulkarni
2017-10-16 18:32 ` [PATCH v9 3/5] perf utils: use pmu->is_uncore to detect PMU UNCORE devices Ganapatrao Kulkarni
2017-12-05 2:12 ` Jin, Yao
2017-12-05 7:12 ` Ganapatrao Kulkarni
2017-12-05 7:23 ` Jin, Yao
2017-12-05 12:35 ` Jin, Yao
2017-12-05 13:56 ` Arnaldo Carvalho de Melo
2017-12-05 14:02 ` Ganapatrao Kulkarni
2017-12-05 18:42 ` Arnaldo Carvalho de Melo
2017-12-06 0:30 ` Jin, Yao
2017-12-06 13:47 ` Arnaldo Carvalho de Melo
2017-12-07 0:49 ` Jin, Yao
2017-12-05 13:58 ` Arnaldo Carvalho de Melo
2017-10-16 18:32 ` [PATCH v9 4/5] perf vendor events arm64: Add ThunderX2 implementation defined pmu core events Ganapatrao Kulkarni
2017-12-06 16:39 ` [tip:perf/core] " tip-bot for Ganapatrao Kulkarni
2017-10-16 18:32 ` [PATCH v9 5/5] perf utils: add check for valid cpuid in function perf_pmu__find_map Ganapatrao Kulkarni
2017-12-06 16:40 ` tip-bot for Ganapatrao Kulkarni [this message]
2017-10-18 17:49 ` [PATCH v9 0/5] Add support for ThunderX2 pmu events using json files Ganapatrao Kulkarni
2017-11-06 9:01 ` John Garry
2017-11-07 1:23 ` Will Deacon
2017-11-27 10:04 ` John Garry
2017-12-04 4:41 ` Ganapatrao Kulkarni
2017-12-04 15:09 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-de3d0f12be476271d03f1ddb5a7c241c2f07f126@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=catalin.marinas@arm.com \
--cc=ganapatrao.kulkarni@cavium.com \
--cc=gklkml16@gmail.com \
--cc=hpa@zytor.com \
--cc=jnair@caviumnetworks.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=robert.richter@cavium.com \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome