From: "tip-bot for H. Peter Anvin" <hpa@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
sfr@canb.auug.org.au, tglx@linutronix.de
Subject: [tip:x86/urgent] x86, relocs: Add jiffies and jiffies_64 to the relative whitelist
Date: Thu, 24 May 2012 09:09:38 -0700 [thread overview]
Message-ID: <tip-ea17e7414bc62e8d3bde8d08e3df1d921c518c17@git.kernel.org> (raw)
In-Reply-To: <20120524171604.0d98284f3affc643e9714470@canb.auug.org.au>
Commit-ID: ea17e7414bc62e8d3bde8d08e3df1d921c518c17
Gitweb: http://git.kernel.org/tip/ea17e7414bc62e8d3bde8d08e3df1d921c518c17
Author: H. Peter Anvin <hpa@zytor.com>
AuthorDate: Thu, 24 May 2012 07:01:38 -0700
Committer: H. Peter Anvin <hpa@zytor.com>
CommitDate: Thu, 24 May 2012 07:16:18 -0700
x86, relocs: Add jiffies and jiffies_64 to the relative whitelist
The symbol jiffies is created in the linker script as an alias to
jiffies_64. Unfortunately this is done outside any section, and
apparently GNU ld 2.21 doesn't carry the section with it, so we end up
with an absolute symbol and therefore a broken kernel.
Add jiffies and jiffies_64 to the whitelist.
The most disturbing bit with this discovery is that it shows that we
have had multiple linker bugs in this area crossing multiple
generations, and have been silently building bad kernels for some time.
Link: http://lkml.kernel.org/r/20120524171604.0d98284f3affc643e9714470@canb.auug.org.au
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Cc: <stable@vger.kernel.org> v3.4
---
arch/x86/tools/relocs.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/x86/tools/relocs.c b/arch/x86/tools/relocs.c
index b8f7c65..b685296 100644
--- a/arch/x86/tools/relocs.c
+++ b/arch/x86/tools/relocs.c
@@ -71,6 +71,7 @@ static const char * const sym_regex_kernel[S_NSYMTYPES] = {
"__(start|stop)_notes|"
"__end_rodata|"
"__initramfs_start|"
+ "(jiffies|jiffies_64)|"
"_end)$"
};
prev parent reply other threads:[~2012-05-24 16:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 8:54 linux-next: build failure after merge of the final tree Stephen Rothwell
2012-05-21 9:12 ` Ingo Molnar
2012-05-21 9:15 ` Stephen Rothwell
2012-05-22 8:25 ` Stephen Rothwell
2012-05-23 15:35 ` Ingo Molnar
2012-05-24 7:16 ` Stephen Rothwell
2012-05-24 7:22 ` Ingo Molnar
2012-05-24 14:06 ` H. Peter Anvin
2012-05-24 16:09 ` tip-bot for H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-ea17e7414bc62e8d3bde8d08e3df1d921c518c17@git.kernel.org \
--to=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome