From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753915AbcJDIMn (ORCPT ); Tue, 4 Oct 2016 04:12:43 -0400 Received: from terminus.zytor.com ([198.137.202.10]:37402 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753852AbcJDIMl (ORCPT ); Tue, 4 Oct 2016 04:12:41 -0400 Date: Tue, 4 Oct 2016 01:09:47 -0700 From: tip-bot for Colin Ian King Message-ID: Cc: mhiramat@kernel.org, colin.king@canonical.com, ravi.bangoria@linux.vnet.ibm.com, acme@redhat.com, wangnan0@huawei.com, tglx@linutronix.de, mingo@kernel.org, hpa@zytor.com, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org, peterz@infradead.org Reply-To: tglx@linutronix.de, wangnan0@huawei.com, acme@redhat.com, ravi.bangoria@linux.vnet.ibm.com, mhiramat@kernel.org, colin.king@canonical.com, alexander.shishkin@linux.intel.com, peterz@infradead.org, linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org In-Reply-To: <20161003103431.18534-1-colin.king@canonical.com> References: <20161003103431.18534-1-colin.king@canonical.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/urgent] perf probe: Check if *ptr2 is zero and not ptr2 Git-Commit-ID: ead1a57457c0324a167f3f9e3a70e26c2d75fb12 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: ead1a57457c0324a167f3f9e3a70e26c2d75fb12 Gitweb: http://git.kernel.org/tip/ead1a57457c0324a167f3f9e3a70e26c2d75fb12 Author: Colin Ian King AuthorDate: Mon, 3 Oct 2016 11:34:31 +0100 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 3 Oct 2016 11:24:12 -0300 perf probe: Check if *ptr2 is zero and not ptr2 Static anaylsis with cppcheck[1] detected an incorrect comparison: [tools/perf/util/probe-event.c:216]: (warning) Char literal compared with pointer 'ptr2'. Did you intend to dereference it? Dereference ptr2 for the comparison to fix this. 1: https://sourceforge.net/p/cppcheck/wiki/Home/ Signed-off-by: Colin King Cc: Alexander Shishkin Cc: Masami Hiramatsu Cc: Peter Zijlstra Cc: Ravi Bangoria Cc: Wang Nan Fixes: 35726d3a4ca9 ("perf probe: Fix to cut off incompatible chars from group name") Link: http://lkml.kernel.org/r/20161003103431.18534-1-colin.king@canonical.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/probe-event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c index fcfbef0..d281ae2 100644 --- a/tools/perf/util/probe-event.c +++ b/tools/perf/util/probe-event.c @@ -213,7 +213,7 @@ static int convert_exec_to_group(const char *exec, char **result) goto out; } - for (ptr2 = ptr1; ptr2 != '\0'; ptr2++) { + for (ptr2 = ptr1; *ptr2 != '\0'; ptr2++) { if (!isalnum(*ptr2) && *ptr2 != '_') { *ptr2 = '\0'; break;