From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754304AbeAQQhi (ORCPT ); Wed, 17 Jan 2018 11:37:38 -0500 Received: from terminus.zytor.com ([65.50.211.136]:56173 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754109AbeAQQhd (ORCPT ); Wed, 17 Jan 2018 11:37:33 -0500 Date: Wed, 17 Jan 2018 08:34:59 -0800 From: tip-bot for Jin Yao Message-ID: Cc: peterz@infradead.org, tglx@linutronix.de, ak@linux.intel.com, yao.jin@linux.intel.com, hpa@zytor.com, linux-kernel@vger.kernel.org, kan.liang@intel.com, acme@redhat.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, mingo@kernel.org Reply-To: peterz@infradead.org, yao.jin@linux.intel.com, tglx@linutronix.de, ak@linux.intel.com, hpa@zytor.com, kan.liang@intel.com, linux-kernel@vger.kernel.org, acme@redhat.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, mingo@kernel.org In-Reply-To: <1515596433-24653-2-git-send-email-yao.jin@linux.intel.com> References: <1515596433-24653-2-git-send-email-yao.jin@linux.intel.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf report: Improve error msg when no first/last sample time found Git-Commit-ID: eb0b419eff8cf51af8e16cc8c5d2a92d19824266 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: eb0b419eff8cf51af8e16cc8c5d2a92d19824266 Gitweb: https://git.kernel.org/tip/eb0b419eff8cf51af8e16cc8c5d2a92d19824266 Author: Jin Yao AuthorDate: Wed, 10 Jan 2018 23:00:26 +0800 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 17 Jan 2018 10:23:34 -0300 perf report: Improve error msg when no first/last sample time found The following message will be returned to user when executing 'perf report --time' if perf data file doesn't contain the first/last sample time. "HINT: no first/last sample time found in perf data. Please use latest perf binary to execute 'perf record' (if '--buildid-all' is enabled, needs to set '--timestamp-boundary')." Signed-off-by: Jin Yao Reviewed-by: Jiri Olsa Cc: Alexander Shishkin Cc: Andi Kleen Cc: Kan Liang Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1515596433-24653-2-git-send-email-yao.jin@linux.intel.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-report.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index 6593779..7d4f0a5 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c @@ -1300,7 +1300,9 @@ repeat: if (perf_time__parse_str(report.ptime_range, report.time_str) != 0) { if (session->evlist->first_sample_time == 0 && session->evlist->last_sample_time == 0) { - pr_err("No first/last sample time in perf data\n"); + pr_err("HINT: no first/last sample time found in perf data.\n" + "Please use latest perf binary to execute 'perf record'\n" + "(if '--buildid-all' is enabled, please set '--timestamp-boundary').\n"); return -EINVAL; }