From: tip-bot for Dan Carpenter <dan.carpenter@oracle.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, agordeev@redhat.com, hpa@zytor.com,
mingo@kernel.org, yinghai@kernel.org, joerg.roedel@amd.com,
suresh.b.siddha@intel.com, tglx@linutronix.de,
dan.carpenter@oracle.com
Subject: [tip:x86/apic] x86/apic/irq_remap: Silence a bogus pr_err()
Date: Thu, 14 Jun 2012 01:38:29 -0700 [thread overview]
Message-ID: <tip-ed88bed881c9948c4035828c5d63f60c7b015f86@git.kernel.org> (raw)
In-Reply-To: <20120612162633.GA11077@elgon.mountain>
Commit-ID: ed88bed881c9948c4035828c5d63f60c7b015f86
Gitweb: http://git.kernel.org/tip/ed88bed881c9948c4035828c5d63f60c7b015f86
Author: Dan Carpenter <dan.carpenter@oracle.com>
AuthorDate: Tue, 12 Jun 2012 19:26:33 +0300
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 13 Jun 2012 09:51:04 +0200
x86/apic/irq_remap: Silence a bogus pr_err()
There is an extra semicolon here so the pr_err() message is
printed when it is not intended.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Yinghai Lu <yinghai@kernel.org>
Cc: Alexander Gordeev <agordeev@redhat.com>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: Joerg Roedel <joerg.roedel@amd.com>
Link: http://lkml.kernel.org/r/20120612162633.GA11077@elgon.mountain
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
drivers/iommu/intel_irq_remapping.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c
index dafbad0..853902a 100644
--- a/drivers/iommu/intel_irq_remapping.c
+++ b/drivers/iommu/intel_irq_remapping.c
@@ -938,7 +938,7 @@ intel_ioapic_set_affinity(struct irq_data *data, const struct cpumask *mask,
err = apic->cpu_mask_to_apicid_and(cfg->domain, mask, &dest);
if (err) {
- if (assign_irq_vector(irq, cfg, data->affinity));
+ if (assign_irq_vector(irq, cfg, data->affinity))
pr_err("Failed to recover vector for irq %d\n", irq);
return err;
}
prev parent reply other threads:[~2012-06-14 8:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 16:26 [patch -next] irq_remap: silence " Dan Carpenter
2012-06-12 16:44 ` Yinghai Lu
2012-06-14 8:38 ` tip-bot for Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-ed88bed881c9948c4035828c5d63f60c7b015f86@git.kernel.org \
--to=dan.carpenter@oracle.com \
--cc=agordeev@redhat.com \
--cc=hpa@zytor.com \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®