From: tip-bot for Namhyung Kim <namhyung.kim@lge.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, linux-kernel@vger.kernel.org, paulus@samba.org,
hpa@zytor.com, mingo@redhat.com, a.p.zijlstra@chello.nl,
namhyung.kim@lge.com, namhyung@gmail.com, tglx@linutronix.de,
mingo@elte.hu
Subject: [tip:perf/core] perf annotate: Handle lower case key code in annotate_browser__run()
Date: Mon, 5 Mar 2012 08:21:25 -0800 [thread overview]
Message-ID: <tip-ef7c537221160c285704997a913fb66ddc1fe6bc@git.kernel.org> (raw)
In-Reply-To: <1329986784-4916-3-git-send-email-namhyung.kim@lge.com>
Commit-ID: ef7c537221160c285704997a913fb66ddc1fe6bc
Gitweb: http://git.kernel.org/tip/ef7c537221160c285704997a913fb66ddc1fe6bc
Author: Namhyung Kim <namhyung.kim@lge.com>
AuthorDate: Thu, 23 Feb 2012 17:46:21 +0900
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 5 Mar 2012 10:15:50 -0300
perf annotate: Handle lower case key code in annotate_browser__run()
Accepting upper case character only is unconvenient since it requires
SHIFT key too. Why not change to it accept a simple key stroke?
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1329986784-4916-3-git-send-email-namhyung.kim@lge.com
Signed-off-by: Namhyung Kim <namhyung.kim@lge.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/ui/browsers/annotate.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/tools/perf/util/ui/browsers/annotate.c b/tools/perf/util/ui/browsers/annotate.c
index 76caae9..374d3bc5 100644
--- a/tools/perf/util/ui/browsers/annotate.c
+++ b/tools/perf/util/ui/browsers/annotate.c
@@ -287,9 +287,11 @@ static int annotate_browser__run(struct annotate_browser *self, int evidx,
nd = self->curr_hot;
break;
case 'H':
+ case 'h':
nd = self->curr_hot;
break;
case 'S':
+ case 's':
if (annotate_browser__toggle_source(self))
ui_helpline__puts(help);
continue;
next prev parent reply other threads:[~2012-03-05 16:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 8:46 [PATCH 0/5] perf annotate: Random tiny cleanups Namhyung Kim
2012-02-23 8:46 ` [PATCH 1/5] perf annotate: Print asm code as blue when source code is displayed Namhyung Kim
2012-03-05 16:20 ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-02-23 8:46 ` [PATCH 2/5] perf annotate: Handle lower case key code in annotate_browser__run() Namhyung Kim
2012-03-05 16:21 ` tip-bot for Namhyung Kim [this message]
2012-02-23 8:46 ` [PATCH 3/5] perf annotate: Restore title when came back to original symbol Namhyung Kim
2012-03-05 16:22 ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-02-23 8:46 ` [PATCH 4/5] perf annotate: Fix help string on tui Namhyung Kim
2012-03-05 16:23 ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-02-23 8:46 ` [PATCH 5/5] perf annotate: Add missing newline on error message Namhyung Kim
2012-03-05 16:23 ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-03-03 19:36 ` [PATCH 0/5] perf annotate: Random tiny cleanups Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-ef7c537221160c285704997a913fb66ddc1fe6bc@git.kernel.org \
--to=namhyung.kim@lge.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=namhyung@gmail.com \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome