From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932473AbcLHNoZ (ORCPT ); Thu, 8 Dec 2016 08:44:25 -0500 Received: from terminus.zytor.com ([198.137.202.10]:59634 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752088AbcLHNoX (ORCPT ); Thu, 8 Dec 2016 08:44:23 -0500 Date: Thu, 8 Dec 2016 05:43:36 -0800 From: tip-bot for Oleg Nesterov Message-ID: Cc: mingo@kernel.org, oleg@redhat.com, hpa@zytor.com, pmladek@suse.com, roman.penyaev@profitbricks.com, akpm@linux-foundation.org, tglx@linutronix.de, tj@kernel.org, David1.Zhou@amd.com, peterz@infradead.org, luto@amacapital.net, linux-kernel@vger.kernel.org, luto@kernel.org, alexander.deucher@amd.com Reply-To: tglx@linutronix.de, tj@kernel.org, David1.Zhou@amd.com, peterz@infradead.org, luto@amacapital.net, linux-kernel@vger.kernel.org, luto@kernel.org, alexander.deucher@amd.com, mingo@kernel.org, oleg@redhat.com, hpa@zytor.com, roman.penyaev@profitbricks.com, pmladek@suse.com, akpm@linux-foundation.org In-Reply-To: <20161129175100.GA5333@redhat.com> References: <20161129175100.GA5333@redhat.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:sched/core] Revert "kthread: Pin the stack via try_get_task_stack()/put_task_stack() in to_live_kthread() function" Git-Commit-ID: eff9662547f358239b98dfc4a8e6905b494e14d6 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: eff9662547f358239b98dfc4a8e6905b494e14d6 Gitweb: http://git.kernel.org/tip/eff9662547f358239b98dfc4a8e6905b494e14d6 Author: Oleg Nesterov AuthorDate: Tue, 29 Nov 2016 18:51:00 +0100 Committer: Thomas Gleixner CommitDate: Thu, 8 Dec 2016 14:36:18 +0100 Revert "kthread: Pin the stack via try_get_task_stack()/put_task_stack() in to_live_kthread() function" This reverts commit 23196f2e5f5d810578a772785807dcdc2b9fdce9. Now that struct kthread is kmalloc'ed and not longer on the task stack there is no need anymore to pin the stack. Signed-off-by: Oleg Nesterov Acked-by: Peter Zijlstra (Intel) Acked-by: Thomas Gleixner Cc: Chunming Zhou Cc: Roman Pen Cc: Petr Mladek Cc: Andy Lutomirski Cc: Tejun Heo Cc: Andy Lutomirski Cc: Alex Deucher Cc: Andrew Morton Link: http://lkml.kernel.org/r/20161129175100.GA5333@redhat.com Signed-off-by: Thomas Gleixner --- kernel/kthread.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/kernel/kthread.c b/kernel/kthread.c index 9d64b65..7891a94 100644 --- a/kernel/kthread.c +++ b/kernel/kthread.c @@ -88,7 +88,7 @@ void free_kthread_struct(struct task_struct *k) static struct kthread *to_live_kthread(struct task_struct *k) { struct completion *vfork = ACCESS_ONCE(k->vfork_done); - if (likely(vfork) && try_get_task_stack(k)) + if (likely(vfork)) return __to_kthread(vfork); return NULL; } @@ -473,10 +473,8 @@ void kthread_unpark(struct task_struct *k) { struct kthread *kthread = to_live_kthread(k); - if (kthread) { + if (kthread) __kthread_unpark(k, kthread); - put_task_stack(k); - } } EXPORT_SYMBOL_GPL(kthread_unpark); @@ -505,7 +503,6 @@ int kthread_park(struct task_struct *k) wait_for_completion(&kthread->parked); } } - put_task_stack(k); ret = 0; } return ret; @@ -541,7 +538,6 @@ int kthread_stop(struct task_struct *k) __kthread_unpark(k, kthread); wake_up_process(k); wait_for_completion(&kthread->exited); - put_task_stack(k); } ret = k->exit_code; put_task_struct(k);