From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935227AbcHJUiY (ORCPT ); Wed, 10 Aug 2016 16:38:24 -0400 Received: from terminus.zytor.com ([198.137.202.10]:56932 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753129AbcHJSPn (ORCPT ); Wed, 10 Aug 2016 14:15:43 -0400 Date: Wed, 10 Aug 2016 11:14:36 -0700 From: tip-bot for Vegard Nossum Message-ID: Cc: paulmck@linux.vnet.ibm.com, mingo@kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, rusty@rustcorp.com.au, efault@gmx.de, vegard.nossum@oracle.com, peterz@infradead.org, torvalds@linux-foundation.org, hpa@zytor.com Reply-To: hpa@zytor.com, torvalds@linux-foundation.org, vegard.nossum@oracle.com, peterz@infradead.org, rusty@rustcorp.com.au, efault@gmx.de, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@kernel.org, paulmck@linux.vnet.ibm.com, akpm@linux-foundation.org In-Reply-To: <1469216762-19626-1-git-send-email-vegard.nossum@oracle.com> References: <1469216762-19626-1-git-send-email-vegard.nossum@oracle.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:sched/core] sched/debug: Add taint on "BUG: Sleeping function called from invalid context" Git-Commit-ID: f0b22e39e3409109d40ef036b1f46b419e82f58e X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: f0b22e39e3409109d40ef036b1f46b419e82f58e Gitweb: http://git.kernel.org/tip/f0b22e39e3409109d40ef036b1f46b419e82f58e Author: Vegard Nossum AuthorDate: Fri, 22 Jul 2016 21:46:02 +0200 Committer: Ingo Molnar CommitDate: Wed, 10 Aug 2016 16:13:48 +0200 sched/debug: Add taint on "BUG: Sleeping function called from invalid context" Seeing this, it occurs to me that we should probably add a taint here: BUG: sleeping function called from invalid context at mm/slab.h:388 in_atomic(): 0, irqs_disabled(): 0, pid: 32211, name: trinity-c3 Preemption disabled at:[] console_unlock+0x2f7/0x930 CPU: 3 PID: 32211 Comm: trinity-c3 Not tainted 4.7.0-rc7+ #19 ^^^^^^^^^^^ Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Ubuntu-1.8.2-1ubuntu1 04/01/2014 0000000000000000 ffff8800b8a17160 ffffffff81971441 ffff88011a3c4c80 ffff88011a3c4c80 ffff8800b8a17198 ffffffff81158067 0000000000000de6 ffff88011a3c4c80 ffffffff8390e07c 0000000000000184 0000000000000000 Call Trace: [...] BUG: sleeping function called from invalid context at arch/x86/mm/fault.c:1309 in_atomic(): 0, irqs_disabled(): 0, pid: 32211, name: trinity-c3 Preemption disabled at:[] down_trylock+0x13/0x80 CPU: 3 PID: 32211 Comm: trinity-c3 Not tainted 4.7.0-rc7+ #19 ^^^^^^^^^^^ Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Ubuntu-1.8.2-1ubuntu1 04/01/2014 0000000000000000 ffff8800b8a17e08 ffffffff81971441 ffff88011a3c4c80 ffff88011a3c4c80 ffff8800b8a17e40 ffffffff81158067 0000000000000000 ffff88011a3c4c80 ffffffff83437b20 000000000000051d 0000000000000000 Call Trace: [...] Signed-off-by: Vegard Nossum Acked-by: Thomas Gleixner Cc: Andrew Morton Cc: Linus Torvalds Cc: Mike Galbraith Cc: Paul E. McKenney Cc: Peter Zijlstra Cc: Rusty Russel Link: http://lkml.kernel.org/r/1469216762-19626-1-git-send-email-vegard.nossum@oracle.com Signed-off-by: Ingo Molnar --- kernel/sched/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index a656816..3b6b23c 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -7608,6 +7608,7 @@ void ___might_sleep(const char *file, int line, int preempt_offset) pr_cont("\n"); } dump_stack(); + add_taint(TAINT_WARN, LOCKDEP_STILL_OK); } EXPORT_SYMBOL(___might_sleep); #endif