From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756880AbbJ2JmQ (ORCPT ); Thu, 29 Oct 2015 05:42:16 -0400 Received: from terminus.zytor.com ([198.137.202.10]:56153 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751488AbbJ2JmO (ORCPT ); Thu, 29 Oct 2015 05:42:14 -0400 Date: Thu, 29 Oct 2015 02:42:02 -0700 From: tip-bot for Dima Kogan Message-ID: Cc: hpa@zytor.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, dima@secretsauce.net, mingo@kernel.org, acme@redhat.com Reply-To: tglx@linutronix.de, hpa@zytor.com, linux-kernel@vger.kernel.org, acme@redhat.com, mingo@kernel.org, dima@secretsauce.net In-Reply-To: <87si6pfwz4.fsf@secretsauce.net> References: <87si6pfwz4.fsf@secretsauce.net> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf symbols: Fix type error when reading a build-id Git-Commit-ID: f2f3096888569ff1fc15fa0187a39eef3a24b28e X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: f2f3096888569ff1fc15fa0187a39eef3a24b28e Gitweb: http://git.kernel.org/tip/f2f3096888569ff1fc15fa0187a39eef3a24b28e Author: Dima Kogan AuthorDate: Mon, 7 Sep 2015 17:30:28 -0700 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 28 Oct 2015 10:02:00 -0300 perf symbols: Fix type error when reading a build-id This was benign, but wrong. The build-id should live in a char[], not a char*[] Signed-off-by: Dima Kogan Link: http://lkml.kernel.org/r/87si6pfwz4.fsf@secretsauce.net Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/symbol-minimal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/symbol-minimal.c b/tools/perf/util/symbol-minimal.c index fd8477c..4890633 100644 --- a/tools/perf/util/symbol-minimal.c +++ b/tools/perf/util/symbol-minimal.c @@ -337,7 +337,7 @@ int dso__load_sym(struct dso *dso, struct map *map __maybe_unused, symbol_filter_t filter __maybe_unused, int kmodule __maybe_unused) { - unsigned char *build_id[BUILD_ID_SIZE]; + unsigned char build_id[BUILD_ID_SIZE]; int ret; ret = fd__is_64_bit(ss->fd);