From: tip-bot for Ravi Bangoria <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: tglx@linutronix.de, mpe@ellerman.id.au, ananth@in.ibm.com,
dja@axtens.net, linux-kernel@vger.kernel.org, mingo@kernel.org,
acme@redhat.com, hpa@zytor.com, ravi.bangoria@linux.vnet.ibm.com,
anton@ozlabs.org
Subject: [tip:perf/core] perf annotate: Remove unused hist_entry__annotate function
Date: Wed, 29 Jun 2016 02:40:42 -0700 [thread overview]
Message-ID: <tip-f2f4fe4410ac6de96f8561aefeadbb680e5ddc99@git.kernel.org> (raw)
In-Reply-To: <1466769240-12376-2-git-send-email-ravi.bangoria@linux.vnet.ibm.com>
Commit-ID: f2f4fe4410ac6de96f8561aefeadbb680e5ddc99
Gitweb: http://git.kernel.org/tip/f2f4fe4410ac6de96f8561aefeadbb680e5ddc99
Author: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
AuthorDate: Fri, 24 Jun 2016 17:23:55 +0530
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 27 Jun 2016 10:58:50 -0300
perf annotate: Remove unused hist_entry__annotate function
hist_entry__annotate looks part of API but I don't find any caller
of this function. Removing it.
Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: Anton Blanchard <anton@ozlabs.org>
Cc: Daniel Axtens <dja@axtens.net>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Link: http://lkml.kernel.org/r/1466769240-12376-2-git-send-email-ravi.bangoria@linux.vnet.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/annotate.c | 5 -----
tools/perf/util/annotate.h | 2 --
2 files changed, 7 deletions(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 7e5a1e8..b2c7ae4 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -1676,11 +1676,6 @@ int symbol__tty_annotate(struct symbol *sym, struct map *map,
return 0;
}
-int hist_entry__annotate(struct hist_entry *he, size_t privsize)
-{
- return symbol__annotate(he->ms.sym, he->ms.map, privsize);
-}
-
bool ui__has_annotation(void)
{
return use_browser == 1 && perf_hpp_list.sym;
diff --git a/tools/perf/util/annotate.h b/tools/perf/util/annotate.h
index 9241f8c..82f3781 100644
--- a/tools/perf/util/annotate.h
+++ b/tools/perf/util/annotate.h
@@ -156,8 +156,6 @@ void symbol__annotate_zero_histograms(struct symbol *sym);
int symbol__annotate(struct symbol *sym, struct map *map, size_t privsize);
-int hist_entry__annotate(struct hist_entry *he, size_t privsize);
-
int symbol__annotate_init(struct map *map, struct symbol *sym);
int symbol__annotate_printf(struct symbol *sym, struct map *map,
struct perf_evsel *evsel, bool full_paths,
next prev parent reply other threads:[~2016-06-29 9:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 11:53 [RFC 0/6] perf annotate: Enable cross arch annotate Ravi Bangoria
2016-06-24 11:53 ` [RFC 1/6] perf: Remove unused hist_entry__annotate function Ravi Bangoria
2016-06-27 17:35 ` Arnaldo Carvalho de Melo
2016-06-29 9:40 ` tip-bot for Ravi Bangoria [this message]
2016-06-24 11:53 ` [RFC 2/6] perf annotate: Define macro for arch names Ravi Bangoria
2016-06-24 11:53 ` [RFC 3/6] perf annotate: Enable cross arch annotate Ravi Bangoria
2016-06-27 17:16 ` Arnaldo Carvalho de Melo
2016-06-28 11:47 ` Ravi Bangoria
2016-06-24 11:53 ` [RFC 4/6] perf annotate: generalize handling of ret instructions Ravi Bangoria
2016-06-27 17:34 ` Arnaldo Carvalho de Melo
2016-06-29 9:41 ` [tip:perf/core] perf annotate: Generalize handling of 'ret' instructions tip-bot for Naveen N. Rao
2016-06-24 11:53 ` [RFC 5/6] perf annotate: add powerpc support Ravi Bangoria
2016-06-24 11:54 ` [RFC 6/6] perf: add more triplets Ravi Bangoria
2016-06-27 17:34 ` Arnaldo Carvalho de Melo
2016-06-29 9:42 ` [tip:perf/core] perf tools: Add more toolchain triplets tip-bot for Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-f2f4fe4410ac6de96f8561aefeadbb680e5ddc99@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=ananth@in.ibm.com \
--cc=anton@ozlabs.org \
--cc=dja@axtens.net \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=ravi.bangoria@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome