mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Jiang Liu <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: mingo@kernel.org, konrad.wilk@oracle.com, rdunlap@infradead.org,
	tony.luck@intel.com, gregkh@linuxfoundation.org,
	tglx@linutronix.de, hpa@zytor.com, jiang.liu@linux.intel.com,
	grant.likely@linaro.org, linux-kernel@vger.kernel.org,
	yinghai@kernel.org, joro@8bytes.org, bp@alien8.de,
	benh@kernel.crashing.org, bhelgaas@google.com, rjw@rjwysocki.net
Subject: [tip:x86/urgent] x86, irq: Fix build error caused by 9eabc99a635a77cbf09
Date: Mon, 1 Sep 2014 01:15:38 -0700	[thread overview]
Message-ID: <tip-f3761db1646d3ccb9ada2df8e27553a73ef43826@git.kernel.org> (raw)
In-Reply-To: <1409382916-10649-1-git-send-email-jiang.liu@linux.intel.com>

Commit-ID:  f3761db1646d3ccb9ada2df8e27553a73ef43826
Gitweb:     http://git.kernel.org/tip/f3761db1646d3ccb9ada2df8e27553a73ef43826
Author:     Jiang Liu <jiang.liu@linux.intel.com>
AuthorDate: Sat, 30 Aug 2014 15:15:16 +0800
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 1 Sep 2014 10:12:03 +0200

x86, irq: Fix build error caused by 9eabc99a635a77cbf09

Commit 9eabc99a635a77cbf09 causes following build error when
IOAPIC is disabled.
   arch/x86/pci/irq.c: In function 'pirq_disable_irq':
>> arch/x86/pci/irq.c:1259:2: error: implicit declaration of function 'mp_should_keep_irq' [-Werror=implicit-function-declaration]
     if (io_apic_assign_pci_irqs && !mp_should_keep_irq(&dev->dev) &&
     ^
   cc1: some warnings being treated as errors

Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Joerg Roedel <joro@8bytes.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: Yinghai Lu <yinghai@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Grant Likely <grant.likely@linaro.org>
Link: http://lkml.kernel.org/r/1409382916-10649-1-git-send-email-jiang.liu@linux.intel.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/x86/include/asm/io_apic.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/include/asm/io_apic.h b/arch/x86/include/asm/io_apic.h
index 478c490..1733ab4 100644
--- a/arch/x86/include/asm/io_apic.h
+++ b/arch/x86/include/asm/io_apic.h
@@ -239,6 +239,7 @@ static inline int mp_find_ioapic(u32 gsi) { return 0; }
 static inline u32 mp_pin_to_gsi(int ioapic, int pin) { return UINT_MAX; }
 static inline int mp_map_gsi_to_irq(u32 gsi, unsigned int flags) { return gsi; }
 static inline void mp_unmap_irq(int irq) { }
+static inline bool mp_should_keep_irq(struct device *dev) { return 1; }
 
 static inline int save_ioapic_entries(void)
 {

      reply	other threads:[~2014-09-01  8:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-29  9:26 [Patch v4] x86, irq, PCI: Keep IRQ assignment for runtime power management Jiang Liu
2014-08-29 11:40 ` [tip:x86/urgent] " tip-bot for Jiang Liu
2014-08-29 22:09   ` Rafael J. Wysocki
2014-08-29 22:28     ` Rafael J. Wysocki
2014-08-29 14:42 ` [Patch v4] " Rafael J. Wysocki
2014-08-29 23:24   ` Rafael J. Wysocki
2014-08-30  2:44     ` Jiang Liu
2014-09-01 13:52       ` Rafael J. Wysocki
2014-08-30  7:15 ` [Patch v4] x86, irq: Fix build error caused by 9eabc99a635a77cbf09 Jiang Liu
2014-09-01  8:15   ` tip-bot for Jiang Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-f3761db1646d3ccb9ada2df8e27553a73ef43826@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=benh@kernel.crashing.org \
    --cc=bhelgaas@google.com \
    --cc=bp@alien8.de \
    --cc=grant.likely@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=jiang.liu@linux.intel.com \
    --cc=joro@8bytes.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=rjw@rjwysocki.net \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome