mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Jiri Olsa <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: peterz@infradead.org, wangnan0@huawei.com, mingo@kernel.org,
	tglx@linutronix.de, dsahern@gmail.com, namhyung@kernel.org,
	lukasz.odzioba@intel.com, hpa@zytor.com,
	kan.liang@linux.intel.com, jolsa@kernel.org, acme@redhat.com,
	ak@linux.intel.com, linux-kernel@vger.kernel.org,
	alexander.shishkin@linux.intel.com
Subject: [tip:perf/core] perf machine: Add threads__get_last_match function
Date: Wed, 25 Jul 2018 13:50:32 -0700	[thread overview]
Message-ID: <tip-f8b2ebb532e0553b60ae5ad1b84d1d4f0c285752@git.kernel.org> (raw)
In-Reply-To: <20180719143345.12963-2-jolsa@kernel.org>

Commit-ID:  f8b2ebb532e0553b60ae5ad1b84d1d4f0c285752
Gitweb:     https://git.kernel.org/tip/f8b2ebb532e0553b60ae5ad1b84d1d4f0c285752
Author:     Jiri Olsa <jolsa@kernel.org>
AuthorDate: Thu, 19 Jul 2018 16:33:42 +0200
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 24 Jul 2018 14:53:31 -0300

perf machine: Add threads__get_last_match function

Separating threads::last_match cache read/check into separate
threads__get_last_match function. This will be useful in following
patch.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Lukasz Odzioba <lukasz.odzioba@intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/20180719143345.12963-2-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/machine.c | 39 ++++++++++++++++++++++++++-------------
 1 file changed, 26 insertions(+), 13 deletions(-)

diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
index 22dbb6612b41..df41aa1a4cf9 100644
--- a/tools/perf/util/machine.c
+++ b/tools/perf/util/machine.c
@@ -408,23 +408,16 @@ out_err:
 }
 
 /*
- * Caller must eventually drop thread->refcnt returned with a successful
- * lookup/new thread inserted.
+ * Front-end cache - TID lookups come in blocks,
+ * so most of the time we dont have to look up
+ * the full rbtree:
  */
-static struct thread *____machine__findnew_thread(struct machine *machine,
-						  struct threads *threads,
-						  pid_t pid, pid_t tid,
-						  bool create)
+static struct thread*
+threads__get_last_match(struct threads *threads, struct machine *machine,
+			int pid, int tid)
 {
-	struct rb_node **p = &threads->entries.rb_node;
-	struct rb_node *parent = NULL;
 	struct thread *th;
 
-	/*
-	 * Front-end cache - TID lookups come in blocks,
-	 * so most of the time we dont have to look up
-	 * the full rbtree:
-	 */
 	th = threads->last_match;
 	if (th != NULL) {
 		if (th->tid == tid) {
@@ -435,6 +428,26 @@ static struct thread *____machine__findnew_thread(struct machine *machine,
 		threads->last_match = NULL;
 	}
 
+	return NULL;
+}
+
+/*
+ * Caller must eventually drop thread->refcnt returned with a successful
+ * lookup/new thread inserted.
+ */
+static struct thread *____machine__findnew_thread(struct machine *machine,
+						  struct threads *threads,
+						  pid_t pid, pid_t tid,
+						  bool create)
+{
+	struct rb_node **p = &threads->entries.rb_node;
+	struct rb_node *parent = NULL;
+	struct thread *th;
+
+	th = threads__get_last_match(threads, machine, pid, tid);
+	if (th)
+		return th;
+
 	while (*p != NULL) {
 		parent = *p;
 		th = rb_entry(parent, struct thread, rb_node);

  reply	other threads:[~2018-07-25 20:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-19 14:33 [PATCHv2 0/4] perf tools: Fix top crashes Jiri Olsa
2018-07-19 14:33 ` [PATCH 1/4] perf tools: Add threads__get_last_match function Jiri Olsa
2018-07-25 20:50   ` tip-bot for Jiri Olsa [this message]
2018-07-19 14:33 ` [PATCH 2/4] perf tools: Add threads__set_last_match function Jiri Olsa
2018-07-25 20:51   ` [tip:perf/core] perf machine: " tip-bot for Jiri Olsa
2018-07-19 14:33 ` [PATCH 3/4] perf tools: Use last_match threads cache only in single thread mode Jiri Olsa
2018-07-25 20:51   ` [tip:perf/core] perf machine: " tip-bot for Jiri Olsa
2018-07-19 14:33 ` [PATCH 4/4] perf tools: Fix struct comm_str removal crash Jiri Olsa
2018-07-19 15:58   ` Arnaldo Carvalho de Melo
2018-07-19 18:28   ` Arnaldo Carvalho de Melo
2018-07-19 18:31     ` Arnaldo Carvalho de Melo
2018-07-20  1:20       ` Namhyung Kim
2018-07-20 10:17         ` [PATCHv3 " Jiri Olsa
2018-07-20 14:42           ` Arnaldo Carvalho de Melo
2018-07-25 20:52           ` [tip:perf/core] " tip-bot for Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-f8b2ebb532e0553b60ae5ad1b84d1d4f0c285752@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=acme@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=dsahern@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=lukasz.odzioba@intel.com \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome