From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932644AbdJYKU7 (ORCPT ); Wed, 25 Oct 2017 06:20:59 -0400 Received: from terminus.zytor.com ([65.50.211.136]:45433 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932377AbdJYKU5 (ORCPT ); Wed, 25 Oct 2017 06:20:57 -0400 Date: Wed, 25 Oct 2017 03:17:19 -0700 From: tip-bot for Mark Rutland Message-ID: Cc: peterz@infradead.org, paulmck@linux.vnet.ibm.com, viro@zeniv.linux.org.uk, mark.rutland@arm.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, petr@vandrovec.name, mingo@kernel.org, torvalds@linux-foundation.org, hpa@zytor.com Reply-To: tglx@linutronix.de, paulmck@linux.vnet.ibm.com, peterz@infradead.org, viro@zeniv.linux.org.uk, mark.rutland@arm.com, hpa@zytor.com, torvalds@linux-foundation.org, petr@vandrovec.name, linux-kernel@vger.kernel.org, mingo@kernel.org In-Reply-To: <1508792849-3115-5-git-send-email-paulmck@linux.vnet.ibm.com> References: <1508792849-3115-5-git-send-email-paulmck@linux.vnet.ibm.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:locking/core] locking/atomics, fs/ncpfs: Convert ACCESS_ONCE() to READ_ONCE()/WRITE_ONCE() Git-Commit-ID: fd7048adb7a5f3c44154675e0e128fe0f2e16bef X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: fd7048adb7a5f3c44154675e0e128fe0f2e16bef Gitweb: https://git.kernel.org/tip/fd7048adb7a5f3c44154675e0e128fe0f2e16bef Author: Mark Rutland AuthorDate: Mon, 23 Oct 2017 14:07:15 -0700 Committer: Ingo Molnar CommitDate: Wed, 25 Oct 2017 11:00:58 +0200 locking/atomics, fs/ncpfs: Convert ACCESS_ONCE() to READ_ONCE()/WRITE_ONCE() The NCPFS code has some stale comments regarding ACCESS_ONCE() uses which were removed a long time ago. Let's remove the stale comments. Signed-off-by: Mark Rutland Signed-off-by: Paul E. McKenney Cc: Alexander Viro Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Petr Vandrovec Cc: Thomas Gleixner Cc: davem@davemloft.net Cc: linux-arch@vger.kernel.org Cc: mpe@ellerman.id.au Cc: shuah@kernel.org Cc: snitzer@redhat.com Cc: thor.thayer@linux.intel.com Cc: tj@kernel.org Cc: will.deacon@arm.com Link: http://lkml.kernel.org/r/1508792849-3115-5-git-send-email-paulmck@linux.vnet.ibm.com Signed-off-by: Ingo Molnar --- fs/ncpfs/dir.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/fs/ncpfs/dir.c b/fs/ncpfs/dir.c index 088f524..72cfaa2 100644 --- a/fs/ncpfs/dir.c +++ b/fs/ncpfs/dir.c @@ -119,10 +119,6 @@ static inline int ncp_case_sensitive(const struct inode *i) /* * Note: leave the hash unchanged if the directory * is case-sensitive. - * - * Accessing the parent inode can be racy under RCU pathwalking. - * Use ACCESS_ONCE() to make sure we use _one_ particular inode, - * the callers will handle races. */ static int ncp_hash_dentry(const struct dentry *dentry, struct qstr *this) @@ -147,11 +143,6 @@ ncp_hash_dentry(const struct dentry *dentry, struct qstr *this) return 0; } -/* - * Accessing the parent inode can be racy under RCU pathwalking. - * Use ACCESS_ONCE() to make sure we use _one_ particular inode, - * the callers will handle races. - */ static int ncp_compare_dentry(const struct dentry *dentry, unsigned int len, const char *str, const struct qstr *name)