From: tip-bot for Jan Beulich <JBeulich@novell.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
jbeulich@novell.com, JBeulich@novell.com, tglx@linutronix.de,
mingo@elte.hu
Subject: [tip:x86/debug] x86: Combine printk()s in show_regs_common()
Date: Fri, 18 Feb 2011 10:40:01 GMT [thread overview]
Message-ID: <tip-fd8fa4d3ddc4cc04ec8097e632b995d535c52beb@git.kernel.org> (raw)
In-Reply-To: <4D5D535A0200007800032730@vpn.id2.novell.com>
Commit-ID: fd8fa4d3ddc4cc04ec8097e632b995d535c52beb
Gitweb: http://git.kernel.org/tip/fd8fa4d3ddc4cc04ec8097e632b995d535c52beb
Author: Jan Beulich <JBeulich@novell.com>
AuthorDate: Thu, 17 Feb 2011 15:56:58 +0000
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Fri, 18 Feb 2011 08:52:30 +0100
x86: Combine printk()s in show_regs_common()
Printing a single character alone when there's an immediately
following printk() is pretty pointless (and wasteful).
Signed-off-by: Jan Beulich <jbeulich@novell.com>
LKML-Reference: <4D5D535A0200007800032730@vpn.id2.novell.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/process.c | 9 +++------
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
index ff45541..99fa3ad 100644
--- a/arch/x86/kernel/process.c
+++ b/arch/x86/kernel/process.c
@@ -110,12 +110,9 @@ void show_regs_common(void)
init_utsname()->release,
(int)strcspn(init_utsname()->version, " "),
init_utsname()->version);
- printk(KERN_CONT " ");
- printk(KERN_CONT "%s %s", vendor, product);
- if (board) {
- printk(KERN_CONT "/");
- printk(KERN_CONT "%s", board);
- }
+ printk(KERN_CONT " %s %s", vendor, product);
+ if (board)
+ printk(KERN_CONT "/%s", board);
printk(KERN_CONT "\n");
}
next prev parent reply other threads:[~2011-02-18 10:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 15:56 [PATCH] x86: combine " Jan Beulich
2011-02-17 18:53 ` Joe Perches
2011-02-18 10:40 ` tip-bot for Jan Beulich [this message]
2011-02-18 19:41 ` [tip:x86/debug] x86: Combine " Joe Perches
2011-02-18 20:05 ` Ingo Molnar
2011-02-18 20:19 ` Joe Perches
2011-02-18 21:15 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-fd8fa4d3ddc4cc04ec8097e632b995d535c52beb@git.kernel.org \
--to=jbeulich@novell.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome