From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1945983AbcB0Jpo (ORCPT ); Sat, 27 Feb 2016 04:45:44 -0500 Received: from torg.zytor.com ([198.137.202.12]:39476 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756034AbcB0Jpl (ORCPT ); Sat, 27 Feb 2016 04:45:41 -0500 Date: Sat, 27 Feb 2016 01:45:04 -0800 From: tip-bot for Wang Nan Message-ID: Cc: tglx@linutronix.de, hpa@zytor.com, peterz@infradead.org, ast@kernel.org, lizefan@huawei.com, mingo@kernel.org, wangnan0@huawei.com, jolsa@kernel.org, acme@redhat.com, linux-kernel@vger.kernel.org Reply-To: linux-kernel@vger.kernel.org, jolsa@kernel.org, acme@redhat.com, mingo@kernel.org, wangnan0@huawei.com, lizefan@huawei.com, peterz@infradead.org, ast@kernel.org, tglx@linutronix.de, hpa@zytor.com In-Reply-To: <1456479154-136027-6-git-send-email-wangnan0@huawei.com> References: <1456479154-136027-6-git-send-email-wangnan0@huawei.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf tools: Only set filter for tracepoints events Git-Commit-ID: fdf14720fbd02d406ac2c1c50444774b4c7eed9a X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: fdf14720fbd02d406ac2c1c50444774b4c7eed9a Gitweb: http://git.kernel.org/tip/fdf14720fbd02d406ac2c1c50444774b4c7eed9a Author: Wang Nan AuthorDate: Fri, 26 Feb 2016 09:31:53 +0000 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 26 Feb 2016 19:50:01 -0300 perf tools: Only set filter for tracepoints events perf_evlist__set_filter() tries to set filter to every evsel linked in the evlist. However, since filters can only be applied to tracepoints, checking type of evsel before calling perf_evsel__set_filter() would be better. Signed-off-by: Wang Nan Cc: Alexei Starovoitov Cc: Jiri Olsa Cc: Li Zefan Cc: Peter Zijlstra Cc: pi3orama@163.com Link: http://lkml.kernel.org/r/1456479154-136027-6-git-send-email-wangnan0@huawei.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/evlist.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c index c42e196..86a0383 100644 --- a/tools/perf/util/evlist.c +++ b/tools/perf/util/evlist.c @@ -1223,6 +1223,9 @@ int perf_evlist__set_filter(struct perf_evlist *evlist, const char *filter) int err = 0; evlist__for_each(evlist, evsel) { + if (evsel->attr.type != PERF_TYPE_TRACEPOINT) + continue; + err = perf_evsel__set_filter(evsel, filter); if (err) break;