mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Igor Mammedov <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
	imammedo@redhat.com, tglx@linutronix.de, toshi.kani@hp.com
Subject: [tip:x86/urgent] x86/smpboot: Log error on secondary CPU wakeup failure at ERR level
Date: Thu, 5 Jun 2014 10:58:24 -0700	[thread overview]
Message-ID: <tip-feef1e8ecbadf24f8e6829c935df8683cabae41b@git.kernel.org> (raw)
In-Reply-To: <1401975765-22328-3-git-send-email-imammedo@redhat.com>

Commit-ID:  feef1e8ecbadf24f8e6829c935df8683cabae41b
Gitweb:     http://git.kernel.org/tip/feef1e8ecbadf24f8e6829c935df8683cabae41b
Author:     Igor Mammedov <imammedo@redhat.com>
AuthorDate: Thu, 5 Jun 2014 15:42:44 +0200
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 5 Jun 2014 16:33:07 +0200

x86/smpboot: Log error on secondary CPU wakeup failure at ERR level

If system is running without debug level logging,
it will not log error if do_boot_cpu() failed to
wakeup AP. It may lead to silent AP bringup
failures at boot time.
Change message level to KERN_ERR to make error
visible to user as it's done on other architectures.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Acked-by: Toshi Kani <toshi.kani@hp.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1401975765-22328-3-git-send-email-imammedo@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/kernel/smpboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 2988f69..ae2fd975 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -918,7 +918,7 @@ int native_cpu_up(unsigned int cpu, struct task_struct *tidle)
 
 	err = do_boot_cpu(apicid, cpu, tidle);
 	if (err) {
-		pr_debug("do_boot_cpu failed %d\n", err);
+		pr_err("do_boot_cpu failed(%d) to wakeup CPU#%u\n", err, cpu);
 		return -EIO;
 	}
 

  reply	other threads:[~2014-06-05 17:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-05 13:42 [PATCH v6 0/3] x86: fix hang when AP bringup is too slow Igor Mammedov
2014-06-05 13:42 ` [PATCH v6 1/3] x86: fix list/memory corruption on CPU hotplug Igor Mammedov
2014-06-05 17:58   ` [tip:x86/urgent] x86: Fix " tip-bot for Igor Mammedov
2014-06-05 13:42 ` [PATCH v6 2/3] x86: log error on secondary CPU wakeup failure at ERR level Igor Mammedov
2014-06-05 17:58   ` tip-bot for Igor Mammedov [this message]
2014-06-05 13:42 ` [PATCH v6 3/3] x86: initialize secondary CPU only if master CPU will wait for it Igor Mammedov
2014-06-05 17:58   ` [tip:x86/urgent] x86/smpboot: Initialize " tip-bot for Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-feef1e8ecbadf24f8e6829c935df8683cabae41b@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=hpa@zytor.com \
    --cc=imammedo@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=toshi.kani@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome