From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753537AbbE0Qt4 (ORCPT ); Wed, 27 May 2015 12:49:56 -0400 Received: from terminus.zytor.com ([198.137.202.10]:39012 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752842AbbE0Qty (ORCPT ); Wed, 27 May 2015 12:49:54 -0400 Date: Wed, 27 May 2015 09:49:40 -0700 From: tip-bot for Arnaldo Carvalho de Melo Message-ID: Cc: dsahern@gmail.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, hpa@zytor.com, eranian@google.com, namhyung@kernel.org, fweisbec@gmail.com, mingo@kernel.org, adrian.hunter@intel.com, bp@suse.de, acme@redhat.com, jolsa@redhat.com, dzickus@redhat.com Reply-To: dsahern@gmail.com, eranian@google.com, linux-kernel@vger.kernel.org, namhyung@kernel.org, hpa@zytor.com, tglx@linutronix.de, fweisbec@gmail.com, mingo@kernel.org, bp@suse.de, adrian.hunter@intel.com, acme@redhat.com, dzickus@redhat.com, jolsa@redhat.com To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf tools: Remove redundant initialization of thread linkage members Git-Commit-ID: fdce6a4edaada40136f0e61569b938c9a25f61d5 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: fdce6a4edaada40136f0e61569b938c9a25f61d5 Gitweb: http://git.kernel.org/tip/fdce6a4edaada40136f0e61569b938c9a25f61d5 Author: Arnaldo Carvalho de Melo AuthorDate: Fri, 22 May 2015 17:42:37 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 27 May 2015 12:21:44 -0300 perf tools: Remove redundant initialization of thread linkage members A thread moves from a rb tree to a list, but can't be on both, because those linkage members are in a union. This is leftover from when I was debugging thread refcounting and had nuked that union. It is harmless duplication, as RB_CLEAR_NODE() does again what INIT_LIST_HEAD does. Cc: Adrian Hunter Cc: Borislav Petkov Cc: David Ahern Cc: Don Zickus Cc: Frederic Weisbecker Cc: Jiri Olsa Cc: Namhyung Kim Cc: Stephane Eranian Link: http://lkml.kernel.org/n/tip-hmma9lmip6qlhzhgkhp9tzd1@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/thread.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c index 16c28a3..28c4b74 100644 --- a/tools/perf/util/thread.c +++ b/tools/perf/util/thread.c @@ -54,7 +54,6 @@ struct thread *thread__new(pid_t pid, pid_t tid) list_add(&comm->list, &thread->comm_list); atomic_set(&thread->refcnt, 0); - INIT_LIST_HEAD(&thread->node); RB_CLEAR_NODE(&thread->rb_node); } @@ -70,7 +69,6 @@ void thread__delete(struct thread *thread) struct comm *comm, *tmp; BUG_ON(!RB_EMPTY_NODE(&thread->rb_node)); - BUG_ON(!list_empty(&thread->node)); thread_stack__free(thread);