From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932142AbbBZLcQ (ORCPT ); Thu, 26 Feb 2015 06:32:16 -0500 Received: from terminus.zytor.com ([198.137.202.10]:52099 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752193AbbBZLcO (ORCPT ); Thu, 26 Feb 2015 06:32:14 -0500 Date: Thu, 26 Feb 2015 03:31:15 -0800 From: tip-bot for Arnaldo Carvalho de Melo Message-ID: Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, dsahern@gmail.com, fweisbec@gmail.com, dzickus@redhat.com, jolsa@redhat.com, eranian@google.com, adrian.hunter@intel.com, acme@redhat.com, hpa@zytor.com, tglx@linutronix.de, bp@suse.de, namhyung@kernel.org, peterz@infradead.org, efault@gmx.de Reply-To: fweisbec@gmail.com, dsahern@gmail.com, mingo@kernel.org, linux-kernel@vger.kernel.org, bp@suse.de, namhyung@kernel.org, peterz@infradead.org, efault@gmx.de, dzickus@redhat.com, eranian@google.com, jolsa@redhat.com, hpa@zytor.com, adrian.hunter@intel.com, acme@redhat.com, tglx@linutronix.de To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf trace: Only insert blank duration bracket when tracing syscalls Git-Commit-ID: 0808921a14ffa170186288508c807f2166b7d8df X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 0808921a14ffa170186288508c807f2166b7d8df Gitweb: http://git.kernel.org/tip/0808921a14ffa170186288508c807f2166b7d8df Author: Arnaldo Carvalho de Melo AuthorDate: Thu, 19 Feb 2015 21:51:50 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Sun, 22 Feb 2015 22:13:54 -0300 perf trace: Only insert blank duration bracket when tracing syscalls When printing just events, i.e. '--no-sys --ev some:events' it makes no sense to waste screen space. Before: # trace --no-sys --ev probe:* 84481.704 ( ): probe:vfs_getname:(ffffffff811ed023) pathname="/etc/services") 84481.892 ( ): probe:vfs_getname:(ffffffff811ed023) pathname="/etc/services") 84482.230 ( ): probe:vfs_getname:(ffffffff811ed023) pathname="/etc/resolv.conf") 84482.481 ( ): probe:vfs_getname:(ffffffff811ed023) pathname="/etc/hosts") 85097.725 ( ): probe:vfs_getname:(ffffffff811ed023) pathname="/root" # After: # trace --no-sys --ev probe:* 0.000 probe:vfs_getname:(ffffffff811ed023) pathname="/root") 1.711 probe:vfs_getname:(ffffffff811ed023) pathname="/etc/localtime") 2.103 probe:vfs_getname:(ffffffff811ed023) pathname="/etc/localtime") ^C# Cc: Adrian Hunter Cc: Borislav Petkov Cc: David Ahern Cc: Don Zickus Cc: Frederic Weisbecker Cc: Jiri Olsa Cc: Mike Galbraith Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Stephane Eranian Link: http://lkml.kernel.org/n/tip-jhryxgnam8zecq0q0wsy6pyb@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-trace.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index b1c1df9..3a696aa 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin-trace.c @@ -1840,7 +1840,11 @@ static int trace__event_handler(struct trace *trace, struct perf_evsel *evsel, { trace__printf_interrupted_entry(trace, sample); trace__fprintf_tstamp(trace, sample->time, trace->output); - fprintf(trace->output, "(%9.9s): %s:", " ", evsel->name); + + if (trace->trace_syscalls) + fprintf(trace->output, "( ): "); + + fprintf(trace->output, "%s:", evsel->name); if (evsel->tp_format) { event_format__fprintf(evsel->tp_format, sample->cpu,