From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753341AbbETMWM (ORCPT ); Wed, 20 May 2015 08:22:12 -0400 Received: from terminus.zytor.com ([198.137.202.10]:56613 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753193AbbETMWJ (ORCPT ); Wed, 20 May 2015 08:22:09 -0400 Date: Wed, 20 May 2015 05:21:51 -0700 From: tip-bot for Arnaldo Carvalho de Melo Message-ID: Cc: linux-kernel@vger.kernel.org, bp@suse.de, jolsa@redhat.com, namhyung@kernel.org, dzickus@redhat.com, fweisbec@gmail.com, adrian.hunter@intel.com, mingo@kernel.org, acme@redhat.com, eranian@google.com, tglx@linutronix.de, hpa@zytor.com, dsahern@gmail.com Reply-To: namhyung@kernel.org, jolsa@redhat.com, bp@suse.de, linux-kernel@vger.kernel.org, dsahern@gmail.com, tglx@linutronix.de, hpa@zytor.com, eranian@google.com, acme@redhat.com, mingo@kernel.org, adrian.hunter@intel.com, dzickus@redhat.com, fweisbec@gmail.com To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf machine: Stop accessing atomic_t:: counter directly Git-Commit-ID: 59a51c1dc9fbb3fb4af928b852d7b35df83edd74 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 59a51c1dc9fbb3fb4af928b852d7b35df83edd74 Gitweb: http://git.kernel.org/tip/59a51c1dc9fbb3fb4af928b852d7b35df83edd74 Author: Arnaldo Carvalho de Melo AuthorDate: Fri, 15 May 2015 15:32:55 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 15 May 2015 15:32:55 -0300 perf machine: Stop accessing atomic_t::counter directly Use atomic_read(&counter) instead. Cc: Adrian Hunter Cc: Borislav Petkov Cc: David Ahern Cc: Don Zickus Cc: Frederic Weisbecker Cc: Jiri Olsa Cc: Namhyung Kim Cc: Stephane Eranian Link: http://lkml.kernel.org/n/tip-k3hvfvpaut8wp02lzq27muhb@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/machine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c index 34bf89f..daa5591 100644 --- a/tools/perf/util/machine.c +++ b/tools/perf/util/machine.c @@ -1311,7 +1311,7 @@ static void __machine__remove_thread(struct machine *machine, struct thread *th, if (machine->last_match == th) machine->last_match = NULL; - BUG_ON(th->refcnt.counter == 0); + BUG_ON(atomic_read(&th->refcnt) == 0); if (lock) pthread_rwlock_wrlock(&machine->threads_lock); rb_erase(&th->rb_node, &machine->threads);