From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964858AbcJVI6y (ORCPT ); Sat, 22 Oct 2016 04:58:54 -0400 Received: from terminus.zytor.com ([198.137.202.10]:58054 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936428AbcJVI6u (ORCPT ); Sat, 22 Oct 2016 04:58:50 -0400 Date: Sat, 22 Oct 2016 01:58:37 -0700 From: tip-bot for Jiri Olsa Message-ID: Cc: a.p.zijlstra@chello.nl, dsahern@gmail.com, jmario@redhat.com, tglx@linutronix.de, andi@firstfloor.org, mingo@kernel.org, acme@redhat.com, hpa@zytor.com, dzickus@redhat.com, namhyung@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org Reply-To: hpa@zytor.com, jolsa@kernel.org, namhyung@kernel.org, dzickus@redhat.com, linux-kernel@vger.kernel.org, dsahern@gmail.com, a.p.zijlstra@chello.nl, jmario@redhat.com, tglx@linutronix.de, andi@firstfloor.org, mingo@kernel.org, acme@redhat.com To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf c2c report: Add --show-all option Git-Commit-ID: af09b2d35e18f1a377aaa2bc4e5ba4abb98a1088 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: af09b2d35e18f1a377aaa2bc4e5ba4abb98a1088 Gitweb: http://git.kernel.org/tip/af09b2d35e18f1a377aaa2bc4e5ba4abb98a1088 Author: Jiri Olsa AuthorDate: Tue, 11 Oct 2016 13:52:05 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 21 Oct 2016 10:32:02 -0300 perf c2c report: Add --show-all option Normally we limit the main list to contain only entries with HITM % value > 0.0005, but it might be useful to display all captured entries. Adding --show-all option for that. Requested-and-Tested-by: Arnaldo Carvalho de Melo Signed-off-by: Jiri Olsa Cc: Andi Kleen Cc: David Ahern Cc: Don Zickus Cc: Joe Mario Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/n/tip-nokgjdwikbegec5jzj4mxhqc@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/Documentation/perf-c2c.txt | 3 +++ tools/perf/builtin-c2c.c | 7 +++++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/tools/perf/Documentation/perf-c2c.txt b/tools/perf/Documentation/perf-c2c.txt index 33ed456..21810d7 100644 --- a/tools/perf/Documentation/perf-c2c.txt +++ b/tools/perf/Documentation/perf-c2c.txt @@ -97,6 +97,9 @@ REPORT OPTIONS --no-source:: Do not display Source:Line column. +--show-all:: + Show all captured HITM lines, with no regard to HITM % 0.0005 limit. + C2C RECORD ---------- The perf c2c record command setup options related to HITM cacheline analysis diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c index 7eb418d..c6d0dda 100644 --- a/tools/perf/builtin-c2c.c +++ b/tools/perf/builtin-c2c.c @@ -71,6 +71,7 @@ struct perf_c2c { int node_info; bool show_src; + bool show_all; bool use_stdio; bool stats_only; bool symbol_full; @@ -1773,8 +1774,8 @@ static bool he__display(struct hist_entry *he, struct c2c_stats *stats) struct c2c_hist_entry *c2c_he; double ld_dist; - /* XXX Disabled for now, till we get a command line switch to control this */ - return true; + if (c2c.show_all) + return true; c2c_he = container_of(he, struct c2c_hist_entry, he); @@ -2513,6 +2514,8 @@ static int perf_c2c__report(int argc, const char **argv) "Display full length of symbols"), OPT_BOOLEAN(0, "no-source", &no_source, "Do not display Source Line column"), + OPT_BOOLEAN(0, "show-all", &c2c.show_all, + "Show all captured HITM lines."), OPT_CALLBACK_DEFAULT('g', "call-graph", &callchain_param, "print_type,threshold[,print_limit],order,sort_key[,branch],value", callchain_help, &parse_callchain_opt,