From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933715AbcIENVH (ORCPT ); Mon, 5 Sep 2016 09:21:07 -0400 Received: from terminus.zytor.com ([198.137.202.10]:38572 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933234AbcIENVE (ORCPT ); Mon, 5 Sep 2016 09:21:04 -0400 Date: Mon, 5 Sep 2016 06:20:46 -0700 From: tip-bot for Arnaldo Carvalho de Melo Message-ID: Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, wangnan0@huawei.com, dsahern@gmail.com, namhyung@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com, acme@redhat.com, mingo@kernel.org, tglx@linutronix.de Reply-To: tglx@linutronix.de, mingo@kernel.org, acme@redhat.com, adrian.hunter@intel.com, jolsa@kernel.org, namhyung@kernel.org, wangnan0@huawei.com, dsahern@gmail.com, hpa@zytor.com, linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf symbols: Rename ->ignore to ->idle Git-Commit-ID: b55cc4ed202175777690860c482ca2ae5184458e X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: b55cc4ed202175777690860c482ca2ae5184458e Gitweb: http://git.kernel.org/tip/b55cc4ed202175777690860c482ca2ae5184458e Author: Arnaldo Carvalho de Melo AuthorDate: Tue, 30 Aug 2016 11:15:59 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 30 Aug 2016 11:15:59 -0300 perf symbols: Rename ->ignore to ->idle Since this is the only use thus far, and this mechanism is in place for a long time. To clarify why symbols should be skipped or treated differently, name it for the only use it has. Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-oqpf82x2svir611ry15paufd@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-top.c | 4 ++-- tools/perf/util/evsel_fprintf.c | 4 ++-- tools/perf/util/symbol.h | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index e8ca8dc8..e091900 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c @@ -680,7 +680,7 @@ static int symbol_filter(struct map *map, struct symbol *sym) return 1; if (symbol__is_idle(sym)) - sym->ignore = true; + sym->idle = 1; return 0; } @@ -783,7 +783,7 @@ static void perf_event__process_sample(struct perf_tool *tool, } } - if (al.sym == NULL || !al.sym->ignore) { + if (al.sym == NULL || !al.sym->idle) { struct hists *hists = evsel__hists(evsel); struct hist_entry_iter iter = { .evsel = evsel, diff --git a/tools/perf/util/evsel_fprintf.c b/tools/perf/util/evsel_fprintf.c index 3674e77..9111e06 100644 --- a/tools/perf/util/evsel_fprintf.c +++ b/tools/perf/util/evsel_fprintf.c @@ -122,7 +122,7 @@ int sample__fprintf_callchain(struct perf_sample *sample, int left_alignment, if (!node) break; - if (node->sym && node->sym->ignore) + if (node->sym && node->sym->idle) goto next; printed += fprintf(fp, "%-*.*s", left_alignment, left_alignment, " "); @@ -181,7 +181,7 @@ int sample__fprintf_sym(struct perf_sample *sample, struct addr_location *al, if (cursor != NULL) { printed += sample__fprintf_callchain(sample, left_alignment, print_opts, cursor, fp); - } else if (!(al->sym && al->sym->ignore)) { + } else if (!(al->sym && al->sym->idle)) { printed += fprintf(fp, "%-*.*s", left_alignment, left_alignment, " "); if (print_ip) diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h index f6c54d3..e54ee7c 100644 --- a/tools/perf/util/symbol.h +++ b/tools/perf/util/symbol.h @@ -57,7 +57,7 @@ struct symbol { u64 end; u16 namelen; u8 binding; - bool ignore; + u8 idle:1; u8 arch_sym; char name[0]; };