From: tip-bot for Arnaldo Carvalho de Melo <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: tglx@linutronix.de, adrian.hunter@intel.com, acme@redhat.com,
namhyung@kernel.org, linux-kernel@vger.kernel.org, hpa@zytor.com,
fweimer@redhat.com, jolsa@kernel.org, wcohen@redhat.com,
mingo@kernel.org
Subject: [tip:perf/core] perf evswitch: Add the names of on/off events
Date: Fri, 16 Aug 2019 13:53:39 -0700 [thread overview]
Message-ID: <tip-q0og1xoqqi0w38ve5u0a43k2@git.kernel.org> (raw)
Commit-ID: 0b495b121585a1b6ca120fe13f950e2f86ca8197
Gitweb: https://git.kernel.org/tip/0b495b121585a1b6ca120fe13f950e2f86ca8197
Author: Arnaldo Carvalho de Melo <acme@redhat.com>
AuthorDate: Thu, 15 Aug 2019 11:11:14 -0300
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 15 Aug 2019 12:24:42 -0300
perf evswitch: Add the names of on/off events
So that we can have macros for the OPT_ entries and also for finding
those in an evlist, this way other tools will use this very easily.
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Florian Weimer <fweimer@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: William Cohen <wcohen@redhat.com>
Link: https://lkml.kernel.org/n/tip-q0og1xoqqi0w38ve5u0a43k2@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-script.c | 18 ++++++++----------
tools/perf/util/evswitch.h | 1 +
2 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index e7b950e977a9..177e4e91b199 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -3400,8 +3400,6 @@ int cmd_script(int argc, const char **argv)
struct utsname uts;
char *script_path = NULL;
const char **__argv;
- const char *event_switch_on = NULL,
- *event_switch_off = NULL;
int i, j, err = 0;
struct perf_script script = {
.tool = {
@@ -3545,9 +3543,9 @@ int cmd_script(int argc, const char **argv)
"file", "file saving guest os /proc/kallsyms"),
OPT_STRING(0, "guestmodules", &symbol_conf.default_guest_modules,
"file", "file saving guest os /proc/modules"),
- OPT_STRING(0, "switch-on", &event_switch_on,
+ OPT_STRING(0, "switch-on", &script.evswitch.on_name,
"event", "Consider events after the ocurrence of this event"),
- OPT_STRING(0, "switch-off", &event_switch_off,
+ OPT_STRING(0, "switch-off", &script.evswitch.off_name,
"event", "Stop considering events after the ocurrence of this event"),
OPT_BOOLEAN(0, "show-on-off-events", &script.evswitch.show_on_off_events,
"Show the on/off switch events, used with --switch-on"),
@@ -3875,20 +3873,20 @@ int cmd_script(int argc, const char **argv)
script.range_num);
}
- if (event_switch_on) {
- script.evswitch.on = perf_evlist__find_evsel_by_str(session->evlist, event_switch_on);
+ if (script.evswitch.on_name) {
+ script.evswitch.on = perf_evlist__find_evsel_by_str(session->evlist, script.evswitch.on_name);
if (script.evswitch.on == NULL) {
- fprintf(stderr, "switch-on event not found (%s)\n", event_switch_on);
+ fprintf(stderr, "switch-on event not found (%s)\n", script.evswitch.on_name);
err = -ENOENT;
goto out_delete;
}
script.evswitch.discarding = true;
}
- if (event_switch_off) {
- script.evswitch.off = perf_evlist__find_evsel_by_str(session->evlist, event_switch_off);
+ if (script.evswitch.off_name) {
+ script.evswitch.off = perf_evlist__find_evsel_by_str(session->evlist, script.evswitch.off_name);
if (script.evswitch.off == NULL) {
- fprintf(stderr, "switch-off event not found (%s)\n", event_switch_off);
+ fprintf(stderr, "switch-off event not found (%s)\n", script.evswitch.off_name);
err = -ENOENT;
goto out_delete;
}
diff --git a/tools/perf/util/evswitch.h b/tools/perf/util/evswitch.h
index bae3a22ad719..891164504080 100644
--- a/tools/perf/util/evswitch.h
+++ b/tools/perf/util/evswitch.h
@@ -9,6 +9,7 @@ struct evsel;
struct evswitch {
struct evsel *on, *off;
+ const char *on_name, *off_name;
bool discarding;
bool show_on_off_events;
};
reply other threads:[~2019-08-16 20:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-q0og1xoqqi0w38ve5u0a43k2@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=fweimer@redhat.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=tglx@linutronix.de \
--cc=wcohen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®