From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756207AbcJVIie (ORCPT ); Sat, 22 Oct 2016 04:38:34 -0400 Received: from terminus.zytor.com ([198.137.202.10]:56954 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753383AbcJVIic (ORCPT ); Sat, 22 Oct 2016 04:38:32 -0400 Date: Sat, 22 Oct 2016 01:38:18 -0700 From: tip-bot for Jiri Olsa Message-ID: Cc: acme@redhat.com, hpa@zytor.com, jmario@redhat.com, jolsa@kernel.org, dzickus@redhat.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl, dsahern@gmail.com, namhyung@kernel.org, mingo@kernel.org, andi@firstfloor.org Reply-To: andi@firstfloor.org, namhyung@kernel.org, mingo@kernel.org, jmario@redhat.com, jolsa@kernel.org, tglx@linutronix.de, dzickus@redhat.com, dsahern@gmail.com, a.p.zijlstra@chello.nl, linux-kernel@vger.kernel.org, acme@redhat.com, hpa@zytor.com To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf c2c report: Add 'iaddr' dimension key Git-Commit-ID: 43575a95207a88e2f8ccb5e4130a808e325816a7 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 43575a95207a88e2f8ccb5e4130a808e325816a7 Gitweb: http://git.kernel.org/tip/43575a95207a88e2f8ccb5e4130a808e325816a7 Author: Jiri Olsa AuthorDate: Tue, 3 May 2016 21:48:56 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 19 Oct 2016 13:18:31 -0300 perf c2c report: Add 'iaddr' dimension key It displays the code address (as hex number) responsible for the accesses. Using c2c wrapper to standard 'symbol_iaddr' object to define own header and simple (just address) code address output. Signed-off-by: Jiri Olsa Cc: Andi Kleen Cc: David Ahern Cc: Don Zickus Cc: Joe Mario Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/n/tip-rhshygbst6kr75kju0muwt5x@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-c2c.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c index 01d541f..bb9d018 100644 --- a/tools/perf/builtin-c2c.c +++ b/tools/perf/builtin-c2c.c @@ -328,6 +328,27 @@ offset_cmp(struct perf_hpp_fmt *fmt __maybe_unused, return (int64_t)(r - l); } +static int +iaddr_entry(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp, + struct hist_entry *he) +{ + uint64_t addr = 0; + int width = c2c_width(fmt, hpp, he->hists); + char buf[20]; + + if (he->mem_info) + addr = he->mem_info->iaddr.addr; + + return scnprintf(hpp->buf, hpp->size, "%*s", width, HEX_STR(buf, addr)); +} + +static int64_t +iaddr_cmp(struct perf_hpp_fmt *fmt __maybe_unused, + struct hist_entry *left, struct hist_entry *right) +{ + return sort__iaddr_cmp(left, right); +} + #define HEADER_LOW(__h) \ { \ .line[1] = { \ @@ -379,9 +400,18 @@ static struct c2c_dimension dim_offset = { .width = 18, }; +static struct c2c_dimension dim_iaddr = { + .header = HEADER_LOW("Code address"), + .name = "iaddr", + .cmp = iaddr_cmp, + .entry = iaddr_entry, + .width = 18, +}; + static struct c2c_dimension *dimensions[] = { &dim_dcacheline, &dim_offset, + &dim_iaddr, NULL, };