From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932299AbbFSXRs (ORCPT ); Fri, 19 Jun 2015 19:17:48 -0400 Received: from terminus.zytor.com ([198.137.202.10]:52787 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753353AbbFSXRl (ORCPT ); Fri, 19 Jun 2015 19:17:41 -0400 Date: Fri, 19 Jun 2015 16:17:25 -0700 From: tip-bot for Arnaldo Carvalho de Melo Message-ID: Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, bp@suse.de, dzickus@redhat.com, adrian.hunter@intel.com, eranian@google.com, dsahern@gmail.com, mingo@kernel.org, namhyung@kernel.org, fweisbec@gmail.com, hpa@zytor.com, jolsa@redhat.com, acme@redhat.com Reply-To: linux-kernel@vger.kernel.org, tglx@linutronix.de, dsahern@gmail.com, mingo@kernel.org, namhyung@kernel.org, adrian.hunter@intel.com, dzickus@redhat.com, bp@suse.de, eranian@google.com, fweisbec@gmail.com, hpa@zytor.com, jolsa@redhat.com, acme@redhat.com To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf top: Tell the user how to unfreeze events after pressing 'f' Git-Commit-ID: ae3b6ab603bce6a74ca089f7a944196863166a52 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: ae3b6ab603bce6a74ca089f7a944196863166a52 Gitweb: http://git.kernel.org/tip/ae3b6ab603bce6a74ca089f7a944196863166a52 Author: Arnaldo Carvalho de Melo AuthorDate: Fri, 19 Jun 2015 17:35:25 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 19 Jun 2015 18:13:59 -0300 perf top: Tell the user how to unfreeze events after pressing 'f' When the user presses 'f' to disable events the visual cues are, well, the percentages not changing and the number of events freezing. Be more explicit by changing the help line at the bottom of the screen to show the following messages when 'f' is pressed: "Press 'f' again to re-enable the events" And then, when 'f' is pressed again: "Press 'f' to disable the events or 'h' Suggested-by: Ingo Molnar Cc: Adrian Hunter Cc: Borislav Petkov Cc: David Ahern Cc: Don Zickus Cc: Frederic Weisbecker Cc: Jiri Olsa Cc: Namhyung Kim Cc: Stephane Eranian Link: http://lkml.kernel.org/n/tip-uhiswg9a9rxm5gxg7ptjskjn@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-top.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index ccf569a..70a9505 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c @@ -599,7 +599,13 @@ static void *display_thread_tui(void *arg) * No need to refresh, resort/decay histogram entries * if we are not collecting samples: */ - hbt.refresh = top->evlist->enabled ? top->delay_secs : 0; + if (top->evlist->enabled) { + hbt.refresh = top->delay_secs; + help = "Press 'f' to disable the events or 'h' to see other hotkeys"; + } else { + help = "Press 'f' again to re-enable the events"; + hbt.refresh = 0; + } } done = 1; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/