From: tip-bot for Peter Zijlstra <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
a.p.zijlstra@chello.nl, stable@kernel.org, ak@linux.intel.com,
tglx@linutronix.de
Subject: [tip:perf/urgent] perf/x86/intel/lbr: Demand proper privileges for PERF_SAMPLE_BRANCH_KERNEL
Date: Sat, 4 May 2013 01:22:57 -0700 [thread overview]
Message-ID: <tip-v0x9ky3ahzr6nm3c6ilwrili@git.kernel.org> (raw)
In-Reply-To: <20130503121256.230745028@chello.nl>
Commit-ID: 0f5c78b5f33ce940034743e5f9485fc81ad75b0f
Gitweb: http://git.kernel.org/tip/0f5c78b5f33ce940034743e5f9485fc81ad75b0f
Author: Peter Zijlstra <a.p.zijlstra@chello.nl>
AuthorDate: Fri, 3 May 2013 14:11:25 +0200
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Sat, 4 May 2013 08:37:48 +0200
perf/x86/intel/lbr: Demand proper privileges for PERF_SAMPLE_BRANCH_KERNEL
We should always have proper privileges when requesting kernel
data.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: <stable@kernel.org>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: eranian@google.com
Link: http://lkml.kernel.org/r/20130503121256.230745028@chello.nl
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: http://lkml.kernel.org/n/tip-v0x9ky3ahzr6nm3c6ilwrili@git.kernel.org
---
arch/x86/kernel/cpu/perf_event_intel_lbr.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/perf_event_intel_lbr.c b/arch/x86/kernel/cpu/perf_event_intel_lbr.c
index de341d4..0e92871 100644
--- a/arch/x86/kernel/cpu/perf_event_intel_lbr.c
+++ b/arch/x86/kernel/cpu/perf_event_intel_lbr.c
@@ -318,8 +318,11 @@ static void intel_pmu_setup_sw_lbr_filter(struct perf_event *event)
if (br_type & PERF_SAMPLE_BRANCH_USER)
mask |= X86_BR_USER;
- if (br_type & PERF_SAMPLE_BRANCH_KERNEL)
+ if (br_type & PERF_SAMPLE_BRANCH_KERNEL) {
+ if (perf_paranoid_kernel() && !capable(CAP_SYS_ADMIN))
+ return -EACCES;
mask |= X86_BR_KERNEL;
+ }
/* we ignore BRANCH_HV here */
next prev parent reply other threads:[~2013-05-04 8:23 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-03 12:11 [PATCH 0/3] Various perf patches Peter Zijlstra
2013-05-03 12:11 ` [PATCH 1/3] perf, x86: Blacklist all MEM_*_RETIRED events for IVB Peter Zijlstra
2013-05-03 14:35 ` Andi Kleen
2013-05-03 17:00 ` Peter Zijlstra
2013-05-15 14:20 ` Stephane Eranian
2013-05-15 16:51 ` Peter Zijlstra
2013-05-16 15:42 ` Stephane Eranian
2013-05-16 16:07 ` Andi Kleen
2013-05-16 16:26 ` Stephane Eranian
2013-05-04 8:20 ` [tip:perf/urgent] perf/x86: Blacklist all MEM_*_RETIRED events for Ivy Bridge tip-bot for Peter Zijlstra
2013-05-03 12:11 ` [PATCH 2/3] perf, x86, lbr: Fix LBR filter Peter Zijlstra
2013-05-03 14:34 ` Andi Kleen
2013-05-04 6:34 ` Ingo Molnar
2013-05-04 8:21 ` [tip:perf/urgent] perf/x86/intel/lbr: " tip-bot for Peter Zijlstra
2013-05-03 12:11 ` [PATCH 3/3] perf, x86, lbr: Demand proper privileges for PERF_SAMPLE_BRANCH_KERNEL Peter Zijlstra
2013-05-03 14:41 ` Andi Kleen
2013-05-04 8:22 ` tip-bot for Peter Zijlstra [this message]
2013-05-04 11:19 ` [tip:perf/urgent] perf/x86/intel/lbr: " Borislav Petkov
2013-05-05 9:05 ` Ingo Molnar
2013-05-06 8:07 ` Peter Zijlstra
2013-05-06 9:42 ` Ingo Molnar
2013-05-15 13:37 ` [PATCH 3/3] perf, x86, lbr: " Stephane Eranian
2013-05-15 14:30 ` Peter Zijlstra
2013-05-16 9:09 ` Peter Zijlstra
2013-05-16 9:17 ` Peter Zijlstra
2013-05-16 10:09 ` Michael Neuling
2013-05-16 10:15 ` Michael Neuling
2013-05-16 11:16 ` Peter Zijlstra
2013-05-16 15:36 ` Stephane Eranian
2013-05-17 11:12 ` Peter Zijlstra
2013-05-17 11:32 ` Michael Neuling
2013-05-17 11:39 ` Peter Zijlstra
2013-05-17 21:39 ` Stephane Eranian
2013-05-17 22:14 ` Michael Neuling
2013-05-17 22:59 ` Stephane Eranian
2013-05-21 5:41 ` Michael Neuling
2013-05-21 8:50 ` Peter Zijlstra
2013-05-21 13:46 ` Stephane Eranian
2013-05-21 13:55 ` Stephane Eranian
2013-05-22 6:43 ` Anshuman Khandual
2013-05-22 12:23 ` Stephane Eranian
2013-05-22 14:51 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-v0x9ky3ahzr6nm3c6ilwrili@git.kernel.org \
--to=tipbot@zytor.com \
--cc=a.p.zijlstra@chello.nl \
--cc=ak@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®