From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751779AbdGZRRk (ORCPT ); Wed, 26 Jul 2017 13:17:40 -0400 Received: from terminus.zytor.com ([65.50.211.136]:40557 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751454AbdGZRRi (ORCPT ); Wed, 26 Jul 2017 13:17:38 -0400 Date: Wed, 26 Jul 2017 10:15:24 -0700 From: tip-bot for Arnaldo Carvalho de Melo Message-ID: Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, wangnan0@huawei.com, tglx@linutronix.de, dsahern@gmail.com, jolsa@kernel.org, acme@redhat.com, adrian.hunter@intel.com, hpa@zytor.com, namhyung@kernel.org Reply-To: linux-kernel@vger.kernel.org, mingo@kernel.org, dsahern@gmail.com, jolsa@kernel.org, wangnan0@huawei.com, tglx@linutronix.de, adrian.hunter@intel.com, acme@redhat.com, namhyung@kernel.org, hpa@zytor.com To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf trace: Ditch __syscall__arg_val() variant, not needed anymore Git-Commit-ID: 325f5091b0da5a7d8d190262661af17d75bee262 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 325f5091b0da5a7d8d190262661af17d75bee262 Gitweb: http://git.kernel.org/tip/325f5091b0da5a7d8d190262661af17d75bee262 Author: Arnaldo Carvalho de Melo AuthorDate: Wed, 19 Jul 2017 15:02:43 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 20 Jul 2017 09:55:52 -0300 perf trace: Ditch __syscall__arg_val() variant, not needed anymore All callers now can use syscall__arg_val(arg, idx), be it to iterate thru the syscall arguments while taking into account alignment, or to get values for other arguments that affect how the current argument should be formatted (think of fcntl's 'cmd' and 'arg' arguments). Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-wm5b156d8kro1r4y3b33eyta@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-trace.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index fc4d33a..f8b7bfd 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin-trace.c @@ -1336,20 +1336,15 @@ out: * variable to read it. Most notably this avoids extended load instructions * on unaligned addresses */ -static unsigned long __syscall_arg__val(unsigned char *args, u8 idx) +unsigned long syscall_arg__val(struct syscall_arg *arg, u8 idx) { unsigned long val; - unsigned char *p = args + sizeof(unsigned long) * idx; + unsigned char *p = arg->args + sizeof(unsigned long) * idx; memcpy(&val, p, sizeof(val)); return val; } -unsigned long syscall_arg__val(struct syscall_arg *arg, u8 idx) -{ - return __syscall_arg__val(arg->args, idx); -} - static size_t syscall__scnprintf_val(struct syscall *sc, char *bf, size_t size, struct syscall_arg *arg, unsigned long val) {