From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760816AbdKRIin (ORCPT ); Sat, 18 Nov 2017 03:38:43 -0500 Received: from terminus.zytor.com ([65.50.211.136]:56301 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946664AbdKRIid (ORCPT ); Sat, 18 Nov 2017 03:38:33 -0500 Date: Sat, 18 Nov 2017 00:35:21 -0800 From: tip-bot for Arnaldo Carvalho de Melo Message-ID: Cc: linux-kernel@vger.kernel.org, jolsa@kernel.org, mingo@kernel.org, tglx@linutronix.de, namhyung@kernel.org, torvalds@linux-foundation.org, acme@redhat.com, wangnan0@huawei.com, adrian.hunter@intel.com, hpa@zytor.com, dsahern@gmail.com Reply-To: wangnan0@huawei.com, acme@redhat.com, tglx@linutronix.de, namhyung@kernel.org, torvalds@linux-foundation.org, mingo@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, adrian.hunter@intel.com, dsahern@gmail.com, hpa@zytor.com To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf top: Ignore kptr_restrict when not sampling the kernel Git-Commit-ID: b89a5124d2089eec8f090dcd05dd88abaec0cbd2 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: b89a5124d2089eec8f090dcd05dd88abaec0cbd2 Gitweb: https://git.kernel.org/tip/b89a5124d2089eec8f090dcd05dd88abaec0cbd2 Author: Arnaldo Carvalho de Melo AuthorDate: Tue, 14 Nov 2017 13:30:19 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 16 Nov 2017 14:50:02 -0300 perf top: Ignore kptr_restrict when not sampling the kernel If all events have attr.exclude_kernel set, no need to look at kptr_restrict. Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Linus Torvalds Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-yegpzg5bf2im69g0tfizqaqz@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-top.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index 68320ac..8651912 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c @@ -735,14 +735,16 @@ static void perf_event__process_sample(struct perf_tool *tool, if (!machine->kptr_restrict_warned && symbol_conf.kptr_restrict && al.cpumode == PERF_RECORD_MISC_KERNEL) { - ui__warning( + if (!perf_evlist__exclude_kernel(top->session->evlist)) { + ui__warning( "Kernel address maps (/proc/{kallsyms,modules}) are restricted.\n\n" "Check /proc/sys/kernel/kptr_restrict.\n\n" "Kernel%s samples will not be resolved.\n", al.map && !RB_EMPTY_ROOT(&al.map->dso->symbols[MAP__FUNCTION]) ? " modules" : ""); - if (use_browser <= 0) - sleep(5); + if (use_browser <= 0) + sleep(5); + } machine->kptr_restrict_warned = true; }