mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2.6.16.27] ieee1394: sbp2: enable auto spin-up for Maxtor disks
Date: Thu, 10 Aug 2006 18:45:16 +0200 (CEST)	[thread overview]
Message-ID: <tkrat.0cdc5b6163736033@s5r6.in-berlin.de> (raw)
In-Reply-To: <44DB1F19.8000504@s5r6.in-berlin.de>

At least Maxtor OneTouch III require a "start stop unit" command after
auto spin-down before the next access can proceed.  This patch activates
the responsible code in scsi_mod for all Maxtor SBP-2 disks.
https://bugzilla.novell.com/show_bug.cgi?id=183011

Maybe that should be done for all SBP-2 disks, but better be cautious.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
This patch also appeared in 2.6.17.8 and 2.6.18.

Index: linux-2.6.16.27/drivers/ieee1394/sbp2.c
===================================================================
--- linux-2.6.16.27.orig/drivers/ieee1394/sbp2.c	2006-08-10 18:10:13.000000000 +0200
+++ linux-2.6.16.27/drivers/ieee1394/sbp2.c	2006-08-10 18:18:54.000000000 +0200
@@ -2505,6 +2505,9 @@ static int sbp2scsi_slave_configure(stru
 		SBP2_INFO("enabling iPod workaround: decrement disk capacity");
 		sdev->fix_capacity = 1;
 	}
+	if (scsi_id->ne->guid_vendor_id == 0x0010b9 && /* Maxtor's OUI */
+	    (sdev->type == TYPE_DISK || sdev->type == TYPE_RBC))
+		sdev->allow_restart = 1;
 	return 0;
 }
 



  parent reply	other threads:[~2006-08-10 16:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-09 21:45 Adrian Bunk is now taking over the 2.6.16-stable branch Chuck Ebbert
2006-08-09 22:00 ` Adrian Bunk
2006-08-09 22:18   ` Greg KH
2006-08-09 22:45     ` Adrian Bunk
2006-08-09 22:53       ` Greg KH
2006-08-09 23:05         ` Chris Wright
2006-08-09 23:20     ` Rene Scharfe
2006-08-10 11:57   ` Stefan Richter
2006-08-10 16:43     ` [PATCH 2.6.16.27] Fix broken suspend/resume in ohci1394 Stefan Richter
2006-08-10 16:45     ` Stefan Richter [this message]
2006-08-12 16:24     ` Adrian Bunk is now taking over the 2.6.16-stable branch Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tkrat.0cdc5b6163736033@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome