From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux1394-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 3/5] firewire: cdev: fix race of ioctl_send_request with bus reset
Date: Tue, 10 Mar 2009 21:01:08 +0100 (CET) [thread overview]
Message-ID: <tkrat.3179a4eba4a0f5ee@s5r6.in-berlin.de> (raw)
In-Reply-To: <tkrat.700492025c5bb3e8@s5r6.in-berlin.de>
The bus reset handler concurrently frees client->device->node. Use
device->node_id instead. This is equivalent to device->node->node_id
while device->generation is current.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
drivers/firewire/fw-cdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/drivers/firewire/fw-cdev.c
===================================================================
--- linux.orig/drivers/firewire/fw-cdev.c
+++ linux/drivers/firewire/fw-cdev.c
@@ -585,7 +585,7 @@ static int ioctl_send_request(struct cli
return -EINVAL;
}
- return init_request(client, request, client->device->node->node_id,
+ return init_request(client, request, client->device->node_id,
client->device->max_speed);
}
--
Stefan Richter
-=====-==--= --== -=-=-
http://arcgraph.de/sr/
next prev parent reply other threads:[~2009-03-10 20:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-10 19:58 [PATCH 0/5] firewire: cdev interface updates Stefan Richter
2009-03-10 19:59 ` [PATCH 1/5] firewire: cdev: amendment to "add ioctl to query maximum transmission speed" Stefan Richter
2009-03-10 20:00 ` [PATCH 2/5] firewire: cdev: secure add_descriptor ioctl Stefan Richter
2009-03-10 20:01 ` Stefan Richter [this message]
2009-03-10 20:01 ` [PATCH 4/5] firewire: cdev: simplify FW_CDEV_IOC_SEND_REQUEST return value Stefan Richter
2009-03-10 20:02 ` [PATCH 5/5] firewire: cdev: add closure to async stream ioctl Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tkrat.3179a4eba4a0f5ee@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®