From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux1394-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] firewire: ohci: replace empty macros by empty inline functions
Date: Fri, 2 Apr 2010 14:05:47 +0200 (CEST) [thread overview]
Message-ID: <tkrat.32dda143dc8ebd6c@s5r6.in-berlin.de> (raw)
In-Reply-To: <tkrat.4957c3a08e7013b1@s5r6.in-berlin.de>
so that call parameter type checking is available in #ifndef'd builds.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
drivers/firewire/ohci.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
Index: b/drivers/firewire/ohci.c
===================================================================
--- a/drivers/firewire/ohci.c
+++ b/drivers/firewire/ohci.c
@@ -438,9 +438,9 @@ static void log_ar_at_event(char dir, in
#else
-#define log_irqs(evt)
-#define log_selfids(node_id, generation, self_id_count, sid)
-#define log_ar_at_event(dir, speed, header, evt)
+static inline void log_irqs(u32 evt) {}
+static inline void log_selfids(int node_id, int generation, int self_id_count, u32 *s) {}
+static inline void log_ar_at_event(char dir, int speed, u32 *header, int evt) {}
#endif /* CONFIG_FIREWIRE_OHCI_DEBUG */
@@ -2323,8 +2323,8 @@ static void pmac_ohci_off(struct pci_dev
}
}
#else
-#define pmac_ohci_on(dev)
-#define pmac_ohci_off(dev)
+static inline void pmac_ohci_on(struct pci_dev *dev) {}
+static inline void pmac_ohci_off(struct pci_dev *dev) {}
#endif /* CONFIG_PPC_PMAC */
static int __devinit pci_probe(struct pci_dev *dev,
--
Stefan Richter
-=====-==-=- -=-- ---=-
http://arcgraph.de/sr/
next prev parent reply other threads:[~2010-04-02 12:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-02 12:05 [PATCH 1/3] firewire: ohci: function names cleanup Stefan Richter
2010-04-02 12:05 ` Stefan Richter [this message]
2010-04-02 12:06 ` [PATCH 3/3] firewire: ohci: fix nonstandard build without debug facility Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tkrat.32dda143dc8ebd6c@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®