From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux1394-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 4/4] firewire: core: remove condition which is always false
Date: Sat, 17 Jan 2009 22:47:58 +0100 (CET) [thread overview]
Message-ID: <tkrat.34873244488c3e6c@s5r6.in-berlin.de> (raw)
In-Reply-To: <tkrat.ca8b7763ca31e24d@s5r6.in-berlin.de>
reread_bus_info_block() only gets to see devices whose config_rom_length
is at least 6 (ROM header, bus info block, root directory header).
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
drivers/firewire/fw-device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/drivers/firewire/fw-device.c
===================================================================
--- linux.orig/drivers/firewire/fw-device.c
+++ linux/drivers/firewire/fw-device.c
@@ -887,15 +887,15 @@ static int reread_bus_info_block(struct
for (i = 0; i < 6; i++) {
if (read_rom(device, generation, i, &q) != RCODE_COMPLETE)
return REREAD_BIB_ERROR;
if (i == 0 && q == 0)
return REREAD_BIB_GONE;
- if (i > device->config_rom_length || q != device->config_rom[i])
+ if (q != device->config_rom[i])
return REREAD_BIB_CHANGED;
}
return REREAD_BIB_UNCHANGED;
}
static void fw_device_refresh(struct work_struct *work)
--
Stefan Richter
-=====-==--= ---= =---=
http://arcgraph.de/sr/
next prev parent reply other threads:[~2009-01-17 21:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-17 21:45 [PATCH 0/4] firewire: cope with temporary connection loss Stefan Richter
2009-01-17 21:46 ` [PATCH 1/4] firewire: keep highlevel drivers attached during brief " Stefan Richter
2009-01-17 21:46 ` [PATCH 2/4] firewire: core: clean up includes Stefan Richter
2009-01-17 21:47 ` [PATCH 3/4] firewire: core: move some functions Stefan Richter
2009-01-17 21:47 ` Stefan Richter [this message]
2009-01-24 19:35 ` [PATCH 5/4] firewire: core: optimize card shutdown Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tkrat.34873244488c3e6c@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®