mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux1394-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] ieee1394: sbp2: fix bogus s/g access change
Date: Fri, 1 Feb 2008 22:31:10 +0100 (CET)	[thread overview]
Message-ID: <tkrat.4c8ccf852a2999af@s5r6.in-berlin.de> (raw)
In-Reply-To: <tkrat.29809d64b9426d9a@s5r6.in-berlin.de>

sg_dma_len(sg) is invalid before the s/g list is DMA-mapped.

This fixes a post 2.6.24 regression which prevents access to SBP-2
devices on several architectures, introduced by "ieee1394: sbp2: s/g
list access cosmetics", commit 825f1df545ab0289185373b0eaf06fb0b3487422.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
 drivers/ieee1394/sbp2.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Index: linux-2.6.24/drivers/ieee1394/sbp2.c
===================================================================
--- linux-2.6.24.orig/drivers/ieee1394/sbp2.c
+++ linux-2.6.24/drivers/ieee1394/sbp2.c
@@ -1465,10 +1465,9 @@ static void sbp2_prep_command_orb_sg(str
 	orb->misc |= ORB_SET_DIRECTION(orb_direction);
 
 	/* special case if only one element (and less than 64KB in size) */
-	if ((scsi_use_sg == 1) &&
-	    (sg_dma_len(sg) <= SBP2_MAX_SG_ELEMENT_LENGTH)) {
+	if (scsi_use_sg == 1 && sg->length <= SBP2_MAX_SG_ELEMENT_LENGTH) {
 
-		cmd->dma_size = sg_dma_len(sg);
+		cmd->dma_size = sg->length;
 		cmd->dma_type = CMD_DMA_PAGE;
 		cmd->cmd_dma = dma_map_page(hi->host->device.parent,
 					    sg_page(sg), sg->offset,

-- 
Stefan Richter
-=====-==--- --=- ----=
http://arcgraph.de/sr/


  parent reply	other threads:[~2008-02-01 21:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-02 22:03 2.6.24-rc1-54866f032307063776b4eff7eadb131d47f9f9b4 fails to boot: kernel BUG at include/linux/scatterlist.h:49! Torsten Kaiser
2007-11-02 22:32 ` Stefan Richter
2007-11-02 23:16   ` Stefan Richter
2007-11-03  7:03     ` Jens Axboe
2007-11-03 13:14   ` Torsten Kaiser
2007-11-03 14:42     ` Stefan Richter
2007-11-03 16:04       ` Jens Axboe
2007-11-04  8:44         ` Jens Axboe
2007-11-04 10:51           ` Torsten Kaiser
2007-11-04 12:08             ` [PATCH 1/3 2.6.24-rc1-gitX] ieee1394: iso and async streams: s/g list fix Stefan Richter
2007-11-04 12:09               ` [PATCH 2/3 2.6.24-rc1-gitX] ieee1394: sbp2: " Stefan Richter
2007-11-04 12:10                 ` [PATCH 3/3 2.6.24-rc1-gitX] firewire: fw-sbp2: " Stefan Richter
2007-11-04 12:27                 ` [PATCH 2/3 2.6.24-rc1-gitX] ieee1394: sbp2: " Stefan Richter
2007-11-04 13:03             ` 2.6.24-rc1-54866f032307063776b4eff7eadb131d47f9f9b4 fails to boot: kernel BUG at include/linux/scatterlist.h:49! Jens Axboe
2007-11-04 13:19               ` Stefan Richter
2007-11-04 13:26                 ` Jens Axboe
     [not found]                   ` <tkrat.4947ae1f5baa964f@s5r6.in-berlin.de>
     [not found]                     ` <tkrat.2a470664250af864@s5r6.in-berlin.de>
     [not found]                       ` <tkrat.29809d64b9426d9a@s5r6.in-berlin.de>
2008-02-01 21:31                         ` Stefan Richter [this message]
2007-11-04 14:53               ` Torsten Kaiser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tkrat.4c8ccf852a2999af@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome