From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1761618AbYCSWDR@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1761618AbYCSWDR (ORCPT <rfc822;w@1wt.eu>);
	Wed, 19 Mar 2008 18:03:17 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933026AbYCSUZp
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 19 Mar 2008 16:25:45 -0400
Received: from einhorn.in-berlin.de ([192.109.42.8]:37382 "EHLO
	einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756882AbYCSUZm (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 19 Mar 2008 16:25:42 -0400
X-Envelope-From: stefanr@s5r6.in-berlin.de
Date: Wed, 19 Mar 2008 21:24:38 +0100 (CET)
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
Subject: Re: [PATCH 1/2] firewire: catch self_id_count == 0
To: Jarod Wilson <jwilson@redhat.com>
cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
In-Reply-To: <tkrat.b8cbad37fe2bba7b@s5r6.in-berlin.de>
Message-ID: <tkrat.58fb745abe20f01d@s5r6.in-berlin.de>
References: <tkrat.b99824b37365e037@s5r6.in-berlin.de>
 <tkrat.b8cbad37fe2bba7b@s5r6.in-berlin.de>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; CHARSET=us-ascii
Content-Disposition: INLINE
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> I wrote:
>> --- linux.orig/drivers/firewire/fw-topology.c
>> +++ linux/drivers/firewire/fw-topology.c
>> @@ -513,6 +513,11 @@ fw_core_handle_bus_reset(struct fw_card 
>>  
>>  	fw_flush_transactions(card);
>>  
>> +	if (self_id_count == 0) {
>> +		fw_destroy_nodes(card);
>> +		return;
>> +	}
> 
> We may also want to update some other card-> members, pull the topology
> map down, and whatnot...

Or instead of all this:
Don't call fw_core_handle_bus_reset at all if self_id_count == 0?
-- 
Stefan Richter
-=====-==--- --== =--==
http://arcgraph.de/sr/