From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux-kernel@vger.kernel.org, linux1394-devel@lists.sourceforge.net
Cc: "Ismail Dönmez" <ismail@pardus.org.tr>,
"Adrian Bunk" <bunk@stusta.de>, "Greg KH" <greg@kroah.com>,
"Thomas Meyer" <thomas@m3y3r.de>,
"Tobias Diedrich" <ranma@tdiedrich.de>
Subject: [PATCH 2.6.21-rc4] ieee1394: fix oops on "modprobe -r ohci1394" after network class_device conversion
Date: Tue, 20 Mar 2007 22:43:22 +0100 (CET) [thread overview]
Message-ID: <tkrat.5965dca5154c0fa2@s5r6.in-berlin.de> (raw)
In-Reply-To: <200703150249.04169.ismail@pardus.org.tr>
The networking subsystem has been converted from class_device to device
but ieee1394 hasn't. This results in a 100% reproducible NULL pointer
dereference if the ohci1394 driver module is unloaded while the eth1394
module is still loaded.
http://lkml.org/lkml/2006/11/16/147
http://lkml.org/lkml/2007/3/14/4
This is a regression in 2.6.21-rc1.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
Works for me. I still can connect to an OS X box via eth1394 after that
and modprobe -r ohci1394 before modprobe -r eth1394 works again.
Index: linux-2.6.21-rc4/drivers/ieee1394/eth1394.c
===================================================================
--- linux-2.6.21-rc4.orig/drivers/ieee1394/eth1394.c 2007-03-16 19:24:44.000000000 +0100
+++ linux-2.6.21-rc4/drivers/ieee1394/eth1394.c 2007-03-20 22:28:49.000000000 +0100
@@ -586,7 +586,10 @@ static void ether1394_add_host (struct h
}
SET_MODULE_OWNER(dev);
+#if 0
+ /* FIXME - Is this the correct parent device anyway? */
SET_NETDEV_DEV(dev, &host->device);
+#endif
priv = netdev_priv(dev);
--
Stefan Richter
-=====-=-=== --== =-=--
http://arcgraph.de/sr/
next prev parent reply other threads:[~2007-03-20 21:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-14 4:42 Ooops with suspend to RAM Ismail Dönmez
2007-03-14 11:14 ` oops in __nodemgr_remove_host_dev (was Re: Ooops with suspend to RAM) Stefan Richter
2007-03-14 11:45 ` oops in __nodemgr_remove_host_dev Stefan Richter
2007-03-14 16:58 ` oops in __nodemgr_remove_host_dev (was Re: Ooops with suspend to RAM) Ismail Dönmez
2007-03-14 18:25 ` Stefan Richter
2007-03-14 22:51 ` Ismail Dönmez
2007-03-15 0:08 ` Stefan Richter
2007-03-15 0:14 ` Stefan Richter
2007-03-15 0:45 ` Ismail Dönmez
2007-03-15 0:49 ` Ismail Dönmez
2007-03-16 19:46 ` Stefan Richter
2007-03-20 21:43 ` Stefan Richter [this message]
2007-03-20 22:26 ` [PATCH 2.6.21-rc4] ieee1394: fix oops on "modprobe -r ohci1394" after network class_device conversion Ismail Dönmez
2007-03-21 18:11 ` Stefan Richter
2007-03-20 23:34 ` Greg KH
2007-03-21 0:16 ` Stefan Richter
2007-05-13 11:43 ` Stefan Richter
2007-05-20 20:21 ` Stefan Richter
2007-03-14 11:50 ` Ooops with suspend to RAM Adrian Bunk
2007-03-14 16:59 ` Ismail Dönmez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tkrat.5965dca5154c0fa2@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=bunk@stusta.de \
--cc=greg@kroah.com \
--cc=ismail@pardus.org.tr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=ranma@tdiedrich.de \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome