From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux-kernel@vger.kernel.org
Cc: linux1394-devel@lists.sourceforge.net
Subject: <linux/wait.h> requires <linux/sched.h> (was Re: [PATCH 3/4] firewire: get_cycle_timer optimization and cleanup)
Date: Sat, 20 Feb 2010 22:24:43 +0100 (CET) [thread overview]
Message-ID: <tkrat.5fa896f03c3d0c16@s5r6.in-berlin.de> (raw)
In-Reply-To: <tkrat.f36b636501d78192@s5r6.in-berlin.de>
On 14 Feb, Stefan Richter wrote:
> --- linux-2.6.33-rc8.orig/drivers/firewire/core-cdev.c
> +++ linux-2.6.33-rc8/drivers/firewire/core-cdev.c
[...]
> @@ -32,8 +33,6 @@
> #include <linux/module.h>
> #include <linux/mutex.h>
> #include <linux/poll.h>
> -#include <linux/preempt.h>
> -#include <linux/sched.h>
> #include <linux/spinlock.h>
> #include <linux/string.h>
> #include <linux/time.h>
[...]
This doesn't compile on some configurations. core-cdev.c requires (and
includes) linux/wait.h which in turn requires (but does not include)
linux/sched.h.
However, adding #include <linux/sched.h> in wait.h isn't going to be
possible very easily; there are a whole lot of missing definitions in
other headers that are pulled in by sched.h then.
Hence I will simply readd sched.h to firewire/core-cdev.c.
--
Stefan Richter
-=====-==-=- --=- =-=--
http://arcgraph.de/sr/
next prev parent reply other threads:[~2010-02-20 21:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-14 17:44 [PATCH 0/4] firewire: a hardware quirk workaround and related bits Stefan Richter
2010-02-14 17:46 ` [PATCH 1/4 resend] firewire: ohci: work around cycle timer bugs on VIA controllers Stefan Richter
2010-02-14 17:47 ` [PATCH 2/4] firewire: ohci: enable cycle timer fix on ALi and NEC controllers Stefan Richter
2010-02-14 17:47 ` [PATCH 3/4] firewire: get_cycle_timer optimization and cleanup Stefan Richter
2010-02-20 21:24 ` Stefan Richter [this message]
2010-02-14 17:49 ` [PATCH 4/4] firewire: remove incomplete Bus_Time CSR support Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tkrat.5fa896f03c3d0c16@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome