From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753331AbZEXJr3 (ORCPT ); Sun, 24 May 2009 05:47:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752035AbZEXJrS (ORCPT ); Sun, 24 May 2009 05:47:18 -0400 Received: from einhorn.in-berlin.de ([192.109.42.8]:34998 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751530AbZEXJrR (ORCPT ); Sun, 24 May 2009 05:47:17 -0400 X-Envelope-From: stefanr@s5r6.in-berlin.de Date: Sun, 24 May 2009 11:47:04 +0200 (CEST) From: Stefan Richter Subject: Re: [PATCH] ieee1394: eth1394: use "firewire%d" instead of "eth%d" as interface name To: Christian Kujau cc: linux-kernel@vger.kernel.org, linux1394-devel@lists.sourceforge.net, linux-hotplug@vger.kernel.org, netdev@vger.kernel.org In-Reply-To: Message-ID: References: <20090521134856.GA3457@psychotron.englab.brq.redhat.com> <4A1565B6.10907@s5r6.in-berlin.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; CHARSET=us-ascii Content-Disposition: INLINE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christian Kujau wrote at LKML: > If the patch will be accepted at all and it's not too late to ask: I'd > vote for fw%d as well, "firefire" just looks too long, for me at least. I think I'll leave the driver as it is. As I just noticed, we would lose interface renaming by udev. >>From udev/extras/rule_generator/75-persistent-net-generator.rules: # device name whitelist KERNEL!="eth*|ath*|wlan*[0-9]|msh*|ra*|sta*|ctc*|lcs*|hsi*", GOTO="persistent_net_generator_end" Besides, if we can we should avoid fw%d because this will clash with udev rules which match KERNEL=="fw*", as in udev/rules/redhat/40-redhat.rules. -- Stefan Richter -=====-==--= -=-= ==--- http://arcgraph.de/sr/