From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Jean-Baptiste Mur <jeanbaptiste@maunakeatech.com>
Cc: linux1394-devel@lists.sourceforge.net,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ieee1394/ohci1394 : CycleTooLong interrupt management
Date: Fri, 17 Mar 2006 22:01:58 +0100 (CET) [thread overview]
Message-ID: <tkrat.6f7cb1ffe1d70bc4@s5r6.in-berlin.de> (raw)
In-Reply-To: <200603171437.57519.jeanbaptiste@maunakeatech.com>
Jean-Baptiste MUR wrote:
...
> Kernel version : 2.6.16-rc4
(actually plus an ohci1394 patch from the linux1394 development tree)
...
> + /* If this event occurs, we try to reactivate the "cycle
> master" bit. */
> + reg_write(ohci, OHCI1394_LinkControlSet,
> OHCI1394_LinkControl_CycleMaster);
...
Three minor nits:
There are tabs replaced by spaces and superfluous line breaks inserted
in your posting. Take care that the mailer does not mangle whitespace.
If you cannot prevent this nor switch the mailer, send the patch as
attachment without recoding (i.e. 7bit encoding, not base64 or the
like).
Take care of a maximum line length of 80 characters. For example:
/* Try to reactivate the "cycle master" bit. */
reg_write(ohci, OHCI1394_LinkControlSet,
OHCI1394_LinkControl_CycleMaster);
The comment is unnecessary since the actual code is clear enough, at
least IMO.
Anyway, thanks again for identifying this problem.
--
Stefan Richter
-=====-=-==- --== =---=
http://arcgraph.de/sr/
next prev parent reply other threads:[~2006-03-17 21:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-17 13:37 Jean-Baptiste MUR
2006-03-17 21:01 ` Stefan Richter [this message]
2006-03-23 9:15 ` Jean-Baptiste MUR
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tkrat.6f7cb1ffe1d70bc4@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=jeanbaptiste@maunakeatech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome