From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Miles Lane <miles.lane@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
Arjan van de Ven <arjan@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
linux-scsi@vger.kernel.org
Subject: Re: 2.6.18-rc5-mm1 + all hotfixes + nodemgr patches -- INFO: trying to register non-static key (the code is fine but needs lockdep annotation).
Date: Sun, 10 Sep 2006 13:15:33 +0200 (CEST) [thread overview]
Message-ID: <tkrat.ae0a49a0374e41e2@s5r6.in-berlin.de> (raw)
In-Reply-To: <a44ae5cd0609072006p627fb127g62949c62a5bfc6c2@mail.gmail.com>
On 7 Sep, Miles Lane wrote to linux-kernel:
[...]
> ieee1394: sbp2: aborting sbp2 command
> scsi 0:0:0:0:
> command: cdb[0]=0x12: 12 00 00 00 24 00
> INFO: trying to register non-static key.
> the code is fine but needs lockdep annotation.
> turning off the locking correctness validator.
> [<c1003d3a>] dump_trace+0x64/0x1a2
> [<c1003e8a>] show_trace_log_lvl+0x12/0x25
> [<c1004164>] show_trace+0xd/0x10
> [<c100417e>] dump_stack+0x17/0x19
> [<c1038b9c>] __lock_acquire+0x11d/0xa07
> [<c1039763>] lock_acquire+0x5e/0x7f
> [<c11e53b2>] _spin_lock_irq+0x1f/0x2e
> [<c11e3967>] wait_for_completion_timeout+0x2c/0xb9
> [<f902f441>] scsi_send_eh_cmnd+0x20a/0x318 [scsi_mod]
> [<f902f573>] scsi_eh_tur+0x24/0x4c [scsi_mod]
> [<f902fc29>] scsi_error_handler+0x1b2/0x599 [scsi_mod]
> [<c1032b1d>] kthread+0xc4/0xf3
> [<c10039d3>] kernel_thread_helper+0x7/0x10
> DWARF2 unwinder stuck at kernel_thread_helper+0x7/0x10
[...]
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
Subject: SCSI: lockdep annotation in scsi_send_eh_cmnd
Fixup for lockdep enabled kernels: Annotate an on-stack completion.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
Index: linux-2.6.18-rc6-mm1/drivers/scsi/scsi_error.c
===================================================================
--- linux-2.6.18-rc6-mm1.orig/drivers/scsi/scsi_error.c 2006-08-28 21:33:31.000000000 +0200
+++ linux-2.6.18-rc6-mm1/drivers/scsi/scsi_error.c 2006-09-10 12:43:51.000000000 +0200
@@ -466,7 +466,7 @@ static int scsi_send_eh_cmnd(struct scsi
struct scsi_device *sdev = scmd->device;
struct Scsi_Host *shost = sdev->host;
int old_result = scmd->result;
- DECLARE_COMPLETION(done);
+ DECLARE_COMPLETION_ONSTACK(done);
unsigned long timeleft;
unsigned long flags;
unsigned char old_cmnd[MAX_COMMAND_SIZE];
next prev parent reply other threads:[~2006-09-10 11:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-08 3:06 Miles Lane
2006-09-10 11:15 ` Stefan Richter [this message]
2006-09-10 11:58 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tkrat.ae0a49a0374e41e2@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=miles.lane@gmail.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®