From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: stable@kernel.org
Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: [patch 2.6.27.y 1/6] firewire: fix setting tag and sy in iso transmission
Date: Mon, 27 Oct 2008 23:26:00 +0100 (CET) [thread overview]
Message-ID: <tkrat.c6c9e197bd5d3af2@s5r6.in-berlin.de> (raw)
In-Reply-To: <tkrat.df6e0a4afb92ef6e@s5r6.in-berlin.de>
Date: Fri, 12 Sep 2008 18:09:55 +0200 (CEST)
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
Reported by Jay Fenlason:
The iso packet control accessors in fw-cdev.c had bogus masks.
Same as commit 7a1003449c693f0d57443c8786bbf19717921ae0.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
drivers/firewire/fw-cdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux/drivers/firewire/fw-cdev.c
===================================================================
--- linux.orig/drivers/firewire/fw-cdev.c
+++ linux/drivers/firewire/fw-cdev.c
@@ -720,8 +720,8 @@ static int ioctl_create_iso_context(stru
#define GET_PAYLOAD_LENGTH(v) ((v) & 0xffff)
#define GET_INTERRUPT(v) (((v) >> 16) & 0x01)
#define GET_SKIP(v) (((v) >> 17) & 0x01)
-#define GET_TAG(v) (((v) >> 18) & 0x02)
-#define GET_SY(v) (((v) >> 20) & 0x04)
+#define GET_TAG(v) (((v) >> 18) & 0x03)
+#define GET_SY(v) (((v) >> 20) & 0x0f)
#define GET_HEADER_LENGTH(v) (((v) >> 24) & 0xff)
static int ioctl_queue_iso(struct client *client, void *buffer)
--
Stefan Richter
-=====-==--- =-=- ==-==
http://arcgraph.de/sr/
next prev parent reply other threads:[~2008-10-27 22:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-27 22:24 [patch 2.6.27.y 0/6] firewire: proposed patches for -stable Stefan Richter
2008-10-27 22:26 ` Stefan Richter [this message]
2008-10-27 22:26 ` [patch 2.6.27.y 2/6] firewire: fix ioctl() return code Stefan Richter
2008-10-27 22:27 ` [patch 2.6.27.y 3/6] firewire: Survive more than 256 bus resets Stefan Richter
2008-10-27 22:28 ` [patch 2.6.27.y 4/6] firewire: fix struct fw_node memory leak Stefan Richter
2008-10-27 22:29 ` [patch 2.6.27.y 5/6] firewire: fw-sbp2: delay first login to avoid retries Stefan Richter
2008-10-27 22:29 ` [patch 2.6.27.y 6/6] firewire: fw-sbp2: fix races Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tkrat.c6c9e197bd5d3af2@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®