mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] firewire: cdev: check write quadlet request length to avoid buffer overflow
Date: Wed, 7 Jul 2010 14:20:52 +0200 (CEST)	[thread overview]
Message-ID: <tkrat.d41b80d60ff7d2cc@s5r6.in-berlin.de> (raw)
In-Reply-To: <4C346B44.2020407@ladisch.de>

On  7 Jul, Clemens Ladisch wrote:
> Stefan Richter wrote:
>> [...] Thus the only problem is that a bogus write quadlet
>> request with user-specified length of < 3 will put 1...4 random bytes
>> into the packet payload.  But this is the user's problem then, not the
>> kernel's.
> 
> But not being initialized, these are the kernel's bytes that get
> disclosed.

Yes.  In which way can this be exploited though?  For all practical
purposes, the signal-to-noise ratio of these 1...4 bytes seems to be 0.
-- 
Stefan Richter
-=====-==-=- -=== --===
http://arcgraph.de/sr/


  reply	other threads:[~2010-07-07 12:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4C29C1CA.1050705@ladisch.de>
2010-07-07  8:46 ` [PATCH] " Stefan Richter
2010-07-07  9:50   ` [PATCH v2] " Stefan Richter
2010-07-07 10:01     ` [PATCH v3] " Stefan Richter
2010-07-07 11:55       ` Clemens Ladisch
2010-07-07 12:20         ` Stefan Richter [this message]
2010-07-07 12:37           ` [PATCH v4] " Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tkrat.d41b80d60ff7d2cc@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=clemens@ladisch.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®