From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux1394-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] firewire: core: use more outbound tlabels
Date: Sun, 14 Jun 2009 11:44:24 +0200 (CEST) [thread overview]
Message-ID: <tkrat.e2bb42d0db655b15@s5r6.in-berlin.de> (raw)
This appears to be a typo. Tlabel is a 6 bits wide datum; we should
wrap it after 63 rather than 31.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
drivers/firewire/core-transaction.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: b/drivers/firewire/core-transaction.c
===================================================================
--- a/drivers/firewire/core-transaction.c
+++ b/drivers/firewire/core-transaction.c
@@ -294,7 +294,7 @@ void fw_send_request(struct fw_card *car
return;
}
- card->current_tlabel = (card->current_tlabel + 1) & 0x1f;
+ card->current_tlabel = (card->current_tlabel + 1) & 0x3f;
card->tlabel_mask |= (1 << tlabel);
t->node_id = destination_id;
--
Stefan Richter
-=====-==--= -==- -===-
http://arcgraph.de/sr/
next reply other threads:[~2009-06-14 9:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-14 9:44 Stefan Richter [this message]
[not found] ` <20090614103656.GT6540@sliepen.org>
[not found] ` <4A34D871.7030708@s5r6.in-berlin.de>
2009-06-14 11:23 ` [PATCH update] " Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tkrat.e2bb42d0db655b15@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®