From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux1394-devel@lists.sourceforge.net
Cc: Dan Dennedy <dan@dennedy.org>, Arnd Bergmann <arnd@arndb.de>,
Petr Vandrovec <petr@vandrovec.name>,
linux-kernel@vger.kernel.org
Subject: [PATCH] ieee1394: raw1394: Add ioctl() for 32bit userland on 64bit kernel, amendment
Date: Mon, 21 May 2007 18:52:06 +0200 (CEST) [thread overview]
Message-ID: <tkrat.e7d6bff54a497889@s5r6.in-berlin.de> (raw)
In-Reply-To: <46514A01.5090803@s5r6.in-berlin.de>
Pointed out by Arnd Bergmann: PPC32 aligns this at 64bit, IA32 packs
it. A kernel-wide available __compat_u64 which is 4-byte aligned on
AMD64 and IA64 would be nicer though.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
drivers/ieee1394/raw1394.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
Index: linux/drivers/ieee1394/raw1394.c
===================================================================
--- linux.orig/drivers/ieee1394/raw1394.c
+++ linux/drivers/ieee1394/raw1394.c
@@ -2814,7 +2814,11 @@ struct raw1394_iso_packets32 {
struct raw1394_cycle_timer32 {
__u32 cycle_timer;
__u64 local_time;
-} __attribute__((packed));
+}
+#if defined(CONFIG_X86_64) || defined(CONFIG_IA64)
+__attribute__((packed))
+#endif
+;
#define RAW1394_IOC_ISO_RECV_PACKETS32 \
_IOW ('#', 0x25, struct raw1394_iso_packets32)
--
Stefan Richter
-=====-=-=== -=-= =-=-=
http://arcgraph.de/sr/
next prev parent reply other threads:[~2007-05-21 16:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-07 2:14 [PATCH] Fix/add raw1394 CONFIG_COMPAT code Petr Vandrovec
2007-05-07 16:40 ` Stefan Richter
2007-05-15 3:52 ` Dan Dennedy
2007-05-15 22:59 ` Stefan Richter
2007-05-15 23:00 ` [PATCH 1/3] ieee1394: raw1394: Fix read() for 32bit userland on 64bit kernel Stefan Richter
2007-05-15 23:01 ` [PATCH 2/3] ieee1394: raw1394: Fix write() " Stefan Richter
2007-05-15 23:02 ` [PATCH 3/3] ieee1394: raw1394: Add ioctl() " Stefan Richter
2007-05-15 23:51 ` [PATCH] Fix/add raw1394 CONFIG_COMPAT code Petr Vandrovec
2007-05-19 23:55 ` Arnd Bergmann
2007-05-20 0:02 ` Stefan Richter
2007-05-20 15:03 ` Arnd Bergmann
2007-05-20 15:28 ` Stefan Richter
2007-05-20 15:37 ` Arnd Bergmann
2007-05-20 15:55 ` Stefan Richter
2007-05-21 7:28 ` Stefan Richter
2007-05-21 16:52 ` Stefan Richter [this message]
2007-05-23 4:54 ` Dan Dennedy
2007-05-23 6:32 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tkrat.e7d6bff54a497889@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=arnd@arndb.de \
--cc=dan@dennedy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=petr@vandrovec.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®