mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux1394-devel@lists.sourceforge.net
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Wolfgang Pfeiffer <roto@gmx.net>,
	Ben Collins <bcollins@ubuntu.com>, Andrew Morton <akpm@osdl.org>
Subject: [PATCH 0/2] ieee1394: ohci1394: endianess bug in verbose debug log
Date: Fri, 8 Sep 2006 01:55:24 +0200 (CEST)	[thread overview]
Message-ID: <tkrat.e9e9aee005df0fb6@s5r6.in-berlin.de> (raw)

This fixes a debug macro on some big endian machines.  Related code is
touched up too to make it harder to introduce such bugs in the future.

 - ieee1394: ohci1394: fix endianess bug in debug message
 - ieee1394: ohci1394: more obvious endianess handling

Wolfgang, could you test and send an ACK?  The tlabel in each "Packet
received from node" message should match that of the previous "Packet
sent to node" line.  Example of a wrong log:
http://www.wolfgangpfeiffer.com/disable-irm.kern.log.when.fw.disk.is.switched.on.txt
The received tlabel was always 48 on this Apple AluBook 5,8.
-- 
Stefan Richter
-=====-=-==- =--= -=---
http://arcgraph.de/sr/


             reply	other threads:[~2006-09-07 23:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-07 23:55 Stefan Richter [this message]
2006-09-07 23:57 ` [PATCH 1/2] ieee1394: ohci1394: fix endianess bug in debug message Stefan Richter
2006-09-07 23:59 ` [PATCH 2/2] ieee1394: ohci1394: more obvious endianess handling Stefan Richter
2006-09-10 13:00 ` [PATCH 0/2] ieee1394: ohci1394: endianess bug in verbose debug log Wolfgang Pfeiffer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tkrat.e9e9aee005df0fb6@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=akpm@osdl.org \
    --cc=bcollins@ubuntu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=roto@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome