From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753969Ab0JVXJJ (ORCPT ); Fri, 22 Oct 2010 19:09:09 -0400 Received: from einhorn.in-berlin.de ([192.109.42.8]:44185 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752070Ab0JVXJI (ORCPT ); Fri, 22 Oct 2010 19:09:08 -0400 X-Envelope-From: stefanr@s5r6.in-berlin.de Date: Sat, 23 Oct 2010 01:08:57 +0200 (CEST) From: Stefan Richter Subject: [PATCH update] firewire: nosy: char device is not seekable To: Arnd Bergmann cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org In-Reply-To: <201010131554.43089.arnd@arndb.de> Message-ID: References: <201010131554.43089.arnd@arndb.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; CHARSET=us-ascii Content-Disposition: INLINE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove unnecessary .llseek handler that came in via an automated mass conversion. .llseek = NULL means no_llseek since commit 776c163b1b93. The only client that uses this interface is nosy-dump in linux/tools/firewire and it knows not to seek in this char dev. Signed-off-by: Stefan Richter --- I left out the addition of return nonseekable_open(...) in nosy_open in this update. This works for nosy, but is it also formally correct? drivers/firewire/nosy.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/firewire/nosy.c b/drivers/firewire/nosy.c index bf184fb..8528b10 100644 --- a/drivers/firewire/nosy.c +++ b/drivers/firewire/nosy.c @@ -405,7 +405,6 @@ static const struct file_operations nosy_ops = { .poll = nosy_poll, .open = nosy_open, .release = nosy_release, - .llseek = noop_llseek, }; #define PHY_PACKET_SIZE 12 /* 1 payload, 1 inverse, 1 ack = 3 quadlets */ -- Stefan Richter -=====-==-=- =-=- =-=== http://arcgraph.de/sr/