From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Arjan van de Ven <arjan@linux.intel.com>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: [PATCH regression fix] x86: fix CONFIG_NONPROMISC_DEVMEM prompt and help text
Date: Thu, 5 Jun 2008 22:37:15 +0200 (CEST) [thread overview]
Message-ID: <tkrat.fcf3166d665fd601@s5r6.in-berlin.de> (raw)
In-Reply-To: <481DC997.3070901@s5r6.in-berlin.de>
Here is an attempt to translate the prompt and help text into something
which is legible and, as a bonus, correct.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
Bogosity already reported on May 4.
Besides, AFAICT it is a security option, not a debug option, hence
misplaced in Kconfig.debug. It would be an actual debug option if the
logic was the inverse: PROMISC_DEVMEM, bool "Promiscuous /dev/mem".
arch/x86/Kconfig.debug | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
Index: linux/arch/x86/Kconfig.debug
===================================================================
--- linux.orig/arch/x86/Kconfig.debug
+++ linux/arch/x86/Kconfig.debug
@@ -6,15 +6,19 @@ config TRACE_IRQFLAGS_SUPPORT
source "lib/Kconfig.debug"
config NONPROMISC_DEVMEM
- bool "Disable promiscuous /dev/mem"
+ bool "Restricted access to /dev/mem"
help
- The /dev/mem file by default only allows userspace access to PCI
- space and the BIOS code and data regions. This is sufficient for
- dosemu and X and all common users of /dev/mem. With this config
- option, you allow userspace access to all of memory, including
- kernel and userspace memory. Accidental access to this is
- obviously disasterous, but specific access can be used by people
- debugging the kernel.
+ If this option is left off, you allow userspace access to all
+ of memory, including kernel and userspace memory. Accidental
+ access to this is obviously disastrous, but specific access can
+ be used by people debugging the kernel.
+
+ If this option is switched on, the /dev/mem file only allows
+ userspace access to PCI space and the BIOS code and data regions.
+ This is sufficient for dosemu and X and all common users of
+ /dev/mem.
+
+ If in doubt, say Y.
config EARLY_PRINTK
bool "Early printk" if EMBEDDED
--
Stefan Richter
-=====-==--- -==- --=-=
http://arcgraph.de/sr/
next prev parent reply other threads:[~2008-06-05 20:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-04 14:35 config NONPROMISC_DEVMEM: help text and logic are confusing Stefan Richter
2008-06-05 20:37 ` Stefan Richter [this message]
2008-06-05 20:47 ` [PATCH regression fix] x86: fix CONFIG_NONPROMISC_DEVMEM prompt and help text Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tkrat.fcf3166d665fd601@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=arjan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®