From: Catalin Marinas <catalin.marinas@arm.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-arch@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Sam Ravnborg <sam@ravnborg.org>,
linux-kbuild@vger.kernel.org,
Randy Dunlap <randy.dunlap@oracle.com>
Subject: Re: kbuild: fixing the select problem
Date: Fri, 07 May 2010 12:31:19 +0100 [thread overview]
Message-ID: <tnxtyqkdk3c.fsf@e102109-lin.cambridge.arm.com> (raw)
In-Reply-To: <1273096160.23208.35.camel@mulgrave.site> (James Bottomley's message of "Wed, 05 May 2010 17:49:20 -0400")
James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> The select problem is that the kbuild select directive will turn a
> symbol on without reference to its dependencies. This, in turn, means
> that either selected symbols must select their dependencies, or that
> people using select have to be aware of the selected symbol's dependency
> and build those dependencies into their symbol (leading to duplication
> and the possibility of getting the dependencies out of sync). We use
> select for the scsi transport classes, so we run into this problem in
> SCSI quite a lot.
>
> I think the correct fix is to make a symbol that selects another symbol
> automatically inherit all of the selected symbol's dependencies.
You may want to have a look at a patch I proposed some time ago, which
at just warns of selecting options with unmet dependencies. I think it's
a better approach that forcing the selection of the dependencies:
http://lkml.org/lkml/2009/9/16/413
--
Catalin
prev parent reply other threads:[~2010-05-07 11:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 21:49 James Bottomley
2010-05-06 6:47 ` Geert Uytterhoeven
2010-05-06 13:17 ` James Bottomley
2010-05-06 13:36 ` Geert Uytterhoeven
2010-05-06 16:47 ` Valdis.Kletnieks
2010-05-06 17:25 ` Geert Uytterhoeven
2010-05-06 14:24 ` Michal Marek
2010-05-06 14:52 ` James Bottomley
2010-05-06 20:48 ` James Bottomley
2010-05-06 20:59 ` Randy Dunlap
2010-05-06 21:05 ` James Bottomley
2010-05-06 16:52 ` Vegard Nossum
2010-05-07 11:31 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tnxtyqkdk3c.fsf@e102109-lin.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®