From: buhr@stat.wisc.edu (Kevin Buhr)
To: Mike Galbraith <mikeg@wen-online.de>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: 2.4.2-ac20 patch for process time double-counting (was: Linux 2.4.2 fails to merge mmap areas, 700% slowdown.)
Date: 23 Mar 2001 15:36:03 -0600 [thread overview]
Message-ID: <vbalmpwxj5o.fsf@mozart.stat.wisc.edu> (raw)
In-Reply-To: <Pine.LNX.4.33.0103230844090.2031-100000@mikeg.weiden.de>
In-Reply-To: Mike Galbraith's message of "Fri, 23 Mar 2001 08:44:59 +0100 (CET)"
Mike Galbraith <mikeg@wen-online.de> writes:
>
> > Mike, would you like to try out the following (untested) patch against
> > vanilla ac20 to see if it does the trick?
>
> Yes, that fixed it.
Great! Can you test one more configuration, please? I can't test it
properly with my SMP motherboard. Under "ac20", if you disable:
Symmetric multi-processing support (CONFIG_SMP)
you'll get to say yes to:
APIC support on uniprocessors (CONFIG_X86_UP_APIC)
If you say yes to that, you'll also get to say yes to:
IO-APIC support on uniprocessors (CONFIG_X86_UP_IOAPIC)
Can you check that the following patch against vanilla "ac20" works
correctly with SMP disabled and X86_UP_APIC enabled? (The original
patch I gave you won't compile with this configuration, since I put
the declaration in the wrong include file.) It shouldn't matter
whether X86_UP_IOAPIC is enabled or disabled.
In addition to checking that the sys/user times look right, please
check for the message:
Using local APIC timer interrupts.
in your boot messages (I *don't* think it'll be there, but I'm not
sure, and I'd really like to know one way or the other). In fact, if
you could send me your kernel messages up to the PCI probe, that would
be ideal.
Thanks muchly!
Kevin <buhr@stat.wisc.edu>
* * *
diff -ru linux-2.4.2-ac20-vanilla/arch/i386/kernel/apic.c linux-2.4.2-ac20/arch/i386/kernel/apic.c
--- linux-2.4.2-ac20-vanilla/arch/i386/kernel/apic.c Fri Mar 23 14:21:47 2001
+++ linux-2.4.2-ac20/arch/i386/kernel/apic.c Fri Mar 23 15:12:15 2001
@@ -30,6 +30,9 @@
#include <asm/mpspec.h>
#include <asm/pgalloc.h>
+/* Using APIC to generate smp_local_timer_interrupt? */
+int using_apic_timer = 0;
+
int prof_multiplier[NR_CPUS] = { 1, };
int prof_old_multiplier[NR_CPUS] = { 1, };
int prof_counter[NR_CPUS] = { 1, };
@@ -872,6 +875,9 @@
void __init setup_APIC_clocks (void)
{
+ printk("Using local APIC timer interrupts.\n");
+ using_apic_timer = 1;
+
__cli();
calibration_result = calibrate_APIC_clock();
diff -ru linux-2.4.2-ac20-vanilla/arch/i386/kernel/time.c linux-2.4.2-ac20/arch/i386/kernel/time.c
--- linux-2.4.2-ac20-vanilla/arch/i386/kernel/time.c Fri Mar 23 14:21:47 2001
+++ linux-2.4.2-ac20/arch/i386/kernel/time.c Fri Mar 23 14:04:43 2001
@@ -422,7 +422,7 @@
if (!user_mode(regs))
x86_do_profile(regs->eip);
#else
- if (!smp_found_config)
+ if (!using_apic_timer)
smp_local_timer_interrupt(regs);
#endif
diff -ru linux-2.4.2-ac20-vanilla/include/asm-i386/mpspec.h linux-2.4.2-ac20/include/asm-i386/mpspec.h
--- linux-2.4.2-ac20-vanilla/include/asm-i386/mpspec.h Mon Jan 8 13:35:28 2001
+++ linux-2.4.2-ac20/include/asm-i386/mpspec.h Fri Mar 23 14:20:19 2001
@@ -182,6 +182,7 @@
extern int mp_current_pci_id;
extern unsigned long mp_lapic_addr;
extern int pic_mode;
+extern int using_apic_timer;
#endif
next prev parent reply other threads:[~2001-03-23 21:37 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-20 18:28 Linux 2.4.2 fails to merge mmap areas, 700% slowdown Serge Orlov
2001-03-20 18:43 ` Linus Torvalds
2001-03-20 18:59 ` Jakob Østergaard
2001-03-21 1:20 ` Kevin Buhr
2001-03-21 6:41 ` Mike Galbraith
2001-03-21 14:56 ` Matthias Urlichs
2001-03-21 15:05 ` Mike Galbraith
2001-03-21 15:59 ` Kurt Garloff
2001-03-21 16:45 ` Mike Galbraith
2001-03-21 20:16 ` Kevin Buhr
2001-03-22 9:04 ` Mike Galbraith
2001-03-22 22:19 ` Kevin Buhr
2001-03-23 7:44 ` Mike Galbraith
2001-03-23 21:36 ` Kevin Buhr [this message]
2001-03-24 7:49 ` 2.4.2-ac20 patch for process time double-counting (was: Linux 2.4.2 fails to merge mmap areas, 700% slowdown.) Mike Galbraith
2001-03-24 19:27 ` Kevin Buhr
2001-03-21 1:38 ` Linux 2.4.2 fails to merge mmap areas, 700% slowdown David S. Miller
2001-03-21 20:19 ` Kevin Buhr
2001-03-22 18:23 ` Kevin Buhr
2001-03-22 18:35 ` Jakob Østergaard
2001-03-23 4:32 ` Kevin Buhr
2001-03-24 4:11 ` Zack Weinberg
2001-03-24 21:46 ` Kevin Buhr
2001-03-24 5:02 ` Linus Torvalds
2001-03-24 9:31 ` Jakob Østergaard
2001-03-24 9:48 ` Jakob Østergaard
2001-03-24 19:54 ` Kevin Buhr
2001-03-25 3:17 ` Jakob Østergaard
2001-03-25 16:47 ` Jamie Lokier
[not found] ` <200103240502.VAA02673@penguin.transmeta.com>
2001-03-24 21:22 ` Kevin Buhr
2001-03-25 3:37 ` Linus Torvalds
2001-03-26 4:22 ` Kevin Buhr
2001-03-23 20:43 ` James Lewis Nance
2001-03-20 18:43 ` Jakob Østergaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vbalmpwxj5o.fsf@mozart.stat.wisc.edu \
--to=buhr@stat.wisc.edu \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mikeg@wen-online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®