From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756812Ab1LNKhI (ORCPT ); Wed, 14 Dec 2011 05:37:08 -0500 Received: from lemon.ertos.nicta.com.au ([203.143.174.143]:52481 "EHLO lemon.ken.nicta.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755283Ab1LNKhF (ORCPT ); Wed, 14 Dec 2011 05:37:05 -0500 Date: Wed, 14 Dec 2011 21:36:32 +1100 Message-ID: From: Peter Chubb To: Russell King - ARM Linux Cc: Peter Chubb , linux-kernel@vger.kernel.org, kexec@lists.infradead.org In-Reply-To: <20111214080836.GA15873@n2100.arm.linux.org.uk> References: <20111214080802.GD14542@n2100.arm.linux.org.uk> <20111214080836.GA15873@n2100.arm.linux.org.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/23.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) X-Face: GgFg(Z>fx((4\32hvXq<)|jndSniCH~~$D)Ka:P@e@JR1P%Vr}EwUdfwf-4j\rUs#JR{'h# !]])6%Jh~b$VA|ALhnpPiHu[-x~@<"@Iv&|%R)Fq[[,(&Z'O)Q)xCqe1\M[F8#9l8~}#u$S$Rm`S9% \'T@`:&8>Sb*c5d'=eDYI&GF`+t[LfDH="MP5rwOO]w>ALi7'=QJHz&y&C&TE_3j! Organization: National ICT Australia MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 2001:388:d000:800:224:d7ff:feaf:390 X-SA-Exim-Mail-From: peter.chubb@nicta.com.au Subject: Re: [PATCH] Fix kexec reboot on ARM X-SA-Exim-Version: 4.2.1 (built Mon, 22 Mar 2010 06:52:44 +0000) X-SA-Exim-Scanned: Yes (on lemon.ken.nicta.com.au) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Russell" == Russell King <- ARM Linux > writes: Russell> On Wed, Dec 14, 2011 at 08:08:02AM +0000, Russell King - ARM Russell> Linux wrote: >> On Wed, Dec 14, 2011 at 03:02:10PM +1100, Peter Chubb wrote: >> > >> > When kexec() runs, it eventually sets up a 1-to-1 memory map, >> then > invokes cpu_reset(). When it invokes cpu_reset (which turns >> > off the MMU), it does so at its virtual address. Across the code >> that > disables the MMU, virtual and physical addresses have to be >> the same, > otherwise after disabling the MMU, the PC is invalid. >> > >> > The simplest fix is to invoke cpu_reset() at its one-to-one >> mapped > address. >> > >> > I've tested on KZM (arm v6) and Beagleboard (omap) >> >> NAK. >> >> Three reasons: >> >> 1. You've not signed-off the patch (please read >> Documentation/SubmittingPatches) 2. pre-ARMv6 do not expect this, >> and it will break where PHYS_OFFSET >= PAGE_OFFSET 3. Have you seen >> what's already queued for the next merge window? Russell> And 4. You didn't cc the linux-arm-kernel mailing list with Russell> your patch. Sure, last time I tried to cc linux-arm it bounced. And I wasn't expecting this to be accepted yet (hence no signed-off-by: line), just wanted comment. If there's already a patch queued to fix this then fine. -- Dr Peter Chubb http://www.gelato.unsw.edu.au peterc AT gelato.unsw.edu.au http://www.ertos.nicta.com.au ERTOS within National ICT Australia -- Dr Peter Chubb http://www.gelato.unsw.edu.au peterc AT gelato.unsw.edu.au http://www.ertos.nicta.com.au ERTOS within National ICT Australia