mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Petr Machata <petrm@mellanox.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, jiri@mellanox.com,
	ilias.apalodimas@linaro.org, Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
	"David S. Miller" <davem@davemloft.net>,
	linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH RFT] net: dsa: Allow configuring CPU port VLANs
Date: Mon, 25 Jun 2018 12:13:10 +0300	[thread overview]
Message-ID: <wih4lhrgrfd.fsf@dev-r-vrt-156.mtr.labs.mlnx> (raw)
In-Reply-To: <20180624153339.13572-1-f.fainelli@gmail.com> (Florian Fainelli's message of "Sun, 24 Jun 2018 08:33:39 -0700")

Florian Fainelli <f.fainelli@gmail.com> writes:

>  	if (netif_is_bridge_master(vlan->obj.orig_dev))
> -		return -EOPNOTSUPP;
> +		info.port = dp->cpu_dp->index;

The condition above will trigger also when a VLAN is added on a member
port, and there's no other port with that VLAN. In that case the VLAN
comes without the BRIDGE_VLAN_INFO_BRENTRY flag. In mlxsw we have this
to get the bridge VLANs:

	if (netif_is_bridge_master(orig_dev)) {
		[...]
		if ((vlan->flags & BRIDGE_VLAN_INFO_BRENTRY) &&
		[...]

This doesn't appear to be done in DSA unless I'm missing something.

Thanks,
Petr

  reply	other threads:[~2018-06-25  9:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-24 15:33 Florian Fainelli
2018-06-25  9:13 ` Petr Machata [this message]
2018-06-25  9:17   ` Ilias Apalodimas
2018-08-10 23:58     ` Florian Fainelli
2018-08-14 18:17       ` Petr Machata
2018-08-14 18:30         ` Florian Fainelli
2018-08-28  8:32       ` Ilias Apalodimas
2018-08-28 16:58         ` Florian Fainelli
2018-08-28 19:08           ` Maxim Uvarov
2018-08-28 19:17             ` Florian Fainelli
2018-08-29  7:14               ` Maxim Uvarov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wih4lhrgrfd.fsf@dev-r-vrt-156.mtr.labs.mlnx \
    --to=petrm@mellanox.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jiri@mellanox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome